Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cairo as lib and not package #1206

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

iloveitaly
Copy link
Contributor

@iloveitaly iloveitaly commented Oct 24, 2024

This is a follow-on from #1178. This needs to be specified as a lib otherwise it won't be picked up by python.

The strange thing I'm running into here is Cairo does not show up in the build information dump:

╔══════════════════════════════ Nixpacks v1.29.0 ══════════════════════════════╗
║ setup      │ python312, gcc                                                  ║
║──────────────────────────────────────────────────────────────────────────────║
║ install    │ python -m venv --copies /opt/venv && . /opt/venv/bin/activate   ║
║            │ && pip install poetry==$NIXPACKS_POETRY_VERSION && poetry       ║
║            │ install --no-dev --no-interaction --no-ansi                     ║
║──────────────────────────────────────────────────────────────────────────────║
║ start      │ python main.py                                                  ║
╚══════════════════════════════════════════════════════════════════════════════╝

the failing lint seems to be unrelated.

@iloveitaly iloveitaly marked this pull request as ready for review October 24, 2024 13:12
Copy link
Contributor

github-actions bot commented Nov 4, 2024

This pull request is stale because it has been open 10 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale The pull request is stale label Nov 4, 2024
@iloveitaly
Copy link
Contributor Author

Friendly reminder about this pull request! Let me know if you need any further assistance.

@coffee-cup coffee-cup removed the stale The pull request is stale label Nov 4, 2024
@coffee-cup coffee-cup added the release/patch Author patch release label Nov 8, 2024
Copy link
Contributor

@coffee-cup coffee-cup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@coffee-cup coffee-cup merged commit c252a8a into railwayapp:main Nov 8, 2024
99 of 100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release/patch Author patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants