Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use openjdk 11 to make maven work on ubuntu 20.04 #64

Merged
merged 4 commits into from
Mar 4, 2022

Conversation

Maaarcocr
Copy link
Contributor

@Maaarcocr Maaarcocr commented Mar 4, 2022

The current version of maven, which comes with ubuntu 20.04, does not work with jdk 16/17 as per https://bugs.launchpad.net/ubuntu/+source/maven/+bug/1930541

In order to have maven working in the docker container, the only solution I could come up with is to go back to jdk 11, while also maintaining ubuntu:20.04 as the base for the image.

Another solution would be to use 21.10. but that's not LTS. Hopefully the new LTS version of ubuntu won't have this problem, but it's not there yet.

The current version of maven, which comes with ubuntu 20.04, does not work with jdk 16/17 as per https://bugs.launchpad.net/ubuntu/+source/maven/+bug/1930541

In order to have maven working in the docker container, the only solution I could come up with is to go back to jdk 11, while also maintaining ubuntu:20.04 as the base for the image. 

Another solution would be to use 21.10. but that's not LTS. Hopefully the new LTS version of ubuntu won't have this problem, but it's not there yet.
@Maaarcocr Maaarcocr changed the title Use jdk 11 as maven does not work with jdk16/17 Use ubuntu 22.04 to make maven work with openjdj 17 Mar 4, 2022
@Maaarcocr Maaarcocr changed the title Use ubuntu 22.04 to make maven work with openjdj 17 Use ubuntu 22.04 to make maven work with openjdk 17 Mar 4, 2022
@larskanis
Copy link
Member

I'd like to avoid the use of Ubuntu-22.04 before it's released. Could you revert to jdk-11?

Also, would you mind to add a simple test case for maven to this repository? To make sure, we don't break it again. Maybe just extend the JRuby part of rcd_test by some maven usage?

@Maaarcocr
Copy link
Contributor Author

I'd like to avoid the use of Ubuntu-22.04 before it's released. Could you revert to jdk-11?

Also, would you mind to add a simple test case for maven to this repository? To make sure, we don't break it again. Maybe just extend the JRuby part of rcd_test by some maven usage?

will do!

@Maaarcocr Maaarcocr changed the title Use ubuntu 22.04 to make maven work with openjdk 17 Use openjdk 17 to make maven work on ubuntu 20.04 Mar 4, 2022
@Maaarcocr Maaarcocr changed the title Use openjdk 17 to make maven work on ubuntu 20.04 Use openjdk 11 to make maven work on ubuntu 20.04 Mar 4, 2022
@larskanis larskanis merged commit cd2afa2 into rake-compiler:master Mar 4, 2022
@larskanis
Copy link
Member

Thank you! Merged.

@Maaarcocr
Copy link
Contributor Author

Maaarcocr commented Mar 4, 2022

Thank you! Merged.

Thank you!

Sorry to bother you, do you have a rough idea of when a release with these changes may happen? Just to know if I should just point to main to unblock something else or I should wait. (It's the end of the week anyway, so it does not matter that much, just mostly curious)

@Maaarcocr Maaarcocr mentioned this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants