building and reproduceability fixes #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @ranahanocka and @galmetzer -- thank you for your work!
I believe this PR:
fixes #10
fixed #31
One of my students -- @Domi2000 -- was working on a wrapper of
point2meshin our OpenISS project to generate meshes from depth-image-based point-clouds and one of our C++ wrappers (OIPoint2MeshAdapter) was for your tool. She had to reproduce the work and modernize dependencies as a result and this is what this PR contributes.Hopefully you and others appreciating your work find this PR useful!
Please also consider the other PR -- #11 -- from another student of mine.
Thanks!