-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated deprecated functions #167
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #167 +/- ##
=======================================
Coverage 83.90% 83.90%
=======================================
Files 24 24
Lines 3498 3498
=======================================
Hits 2935 2935
Misses 563 563 ☔ View full report in Codecov by Sentry. |
Can you please revert the black formatting changes? Can you please also say more about the deprecation, and whether this requires to bump the minimal pandas version? Thanks |
…gories() Signed-off-by: S.J. Guillot <58807831+sjg2203@users.noreply.github.com>
…preferred over 'S' Signed-off-by: S.J. Guillot <58807831+sjg2203@users.noreply.github.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, thanks!
I'll keep the current dependencies as is for now, and might bump pandas in the future |
Updated deprecated functions:
Series.replace()
toSeries.cat.rename_categories()
pd.Timedelta('S')
topd.Timedelta('s')