From f852c8ecc2862dd7ce3e88f308b584b2114f9de5 Mon Sep 17 00:00:00 2001
From: Jade Geels <jade@justbetter.nl>
Date: Thu, 9 Jan 2025 14:53:27 +0100
Subject: [PATCH 1/3] Fix add to cart always redirecting on products with super
 attributes

---
 resources/js/components/Product/AddToCart.vue | 21 ++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)

diff --git a/resources/js/components/Product/AddToCart.vue b/resources/js/components/Product/AddToCart.vue
index eca58d1c..bdd1de6e 100644
--- a/resources/js/components/Product/AddToCart.vue
+++ b/resources/js/components/Product/AddToCart.vue
@@ -59,11 +59,7 @@ export default {
 
     methods: {
         async add() {
-            if (
-                window.location.pathname !== this.product.url &&
-                (this.product?.has_options ||
-                    ('children' in this.product && Object.values(this.product.children).length && !config.show_swatches))
-            ) {
+            if (this.shouldRedirectToProduct) {
                 Turbo.visit(window.url(this.product.url))
                 return
             }
@@ -262,6 +258,21 @@ export default {
     },
 
     computed: {
+        shouldRedirectToProduct: function () {
+            // Never redirect if we're already on the product page
+            if (window.location.pathname === this.product.url) {
+                return false
+            }
+
+            // Products with product options always have to be set on the product page
+            if (this.product?.has_options) {
+                return true
+            }
+
+            // Check if all super_attributes have an option selected
+            return Object.keys(this.product?.super_attributes).join(',') !== Object.keys(this.options).join(',')
+        },
+
         simpleProduct: function () {
             var product = this.product
 

From 224029ebe104606e00e7d5e149ea084aa0d6955a Mon Sep 17 00:00:00 2001
From: Jade Geels <jade@justbetter.nl>
Date: Thu, 9 Jan 2025 15:09:17 +0100
Subject: [PATCH 2/3] Move show_swatches check to only be around the
 super_attributes & thumbnail depends on selected options

---
 resources/js/components/Product/AddToCart.vue |  4 ++
 .../views/listing/partials/item.blade.php     | 56 ++++++++++---------
 .../listing/partials/item/addtocart.blade.php | 34 ++++++-----
 3 files changed, 49 insertions(+), 45 deletions(-)

diff --git a/resources/js/components/Product/AddToCart.vue b/resources/js/components/Product/AddToCart.vue
index bdd1de6e..e8f6e7fc 100644
--- a/resources/js/components/Product/AddToCart.vue
+++ b/resources/js/components/Product/AddToCart.vue
@@ -258,6 +258,10 @@ export default {
     },
 
     computed: {
+        currentThumbnail: function() {
+            return this.simpleProduct?.thumbnail || this.simpleProduct?.images?.[0] || this.product?.thumbnail
+        },
+
         shouldRedirectToProduct: function () {
             // Never redirect if we're already on the product page
             if (window.location.pathname === this.product.url) {
diff --git a/resources/views/listing/partials/item.blade.php b/resources/views/listing/partials/item.blade.php
index 57ac0fa2..f1004772 100644
--- a/resources/views/listing/partials/item.blade.php
+++ b/resources/views/listing/partials/item.blade.php
@@ -1,31 +1,33 @@
 <template {!! isset($slider) ? '' : 'slot="renderItem" slot-scope="{ item, count }"' !!}>
     <div class="my-0.5 w-full h-full shrink-0 snap-start px-0.5 sm:my-2 sm:px-2 sm:w-1/2 lg:w-1/3">
-        <div class="group relative flex flex-1 flex-col rounded border bg-white p-5" :key="item.entity_id">
-            @if (App::providerIsLoaded('Rapidez\Wishlist\WishlistServiceProvider'))
-                <div class="group absolute right-0 top-0 z-10 p-2">
-                    @include('rapidez::wishlist.button')
-                </div>
-            @endif
-            <a :href="item.url | url" class="block">
-                <img
-                    v-if="item.thumbnail"
-                    :src="'/storage/{{ config('rapidez.store') }}/resizes/200/magento/catalog/product' + item.thumbnail + '.webp'"
-                    class="mb-3 h-48 w-full rounded-t object-contain" :alt="item.name" :loading="config.category && count <= 4 ? 'eager' : 'lazy'"
-                    width="200"
-                    height="200"
-                />
-                <x-rapidez::no-image v-else class="mb-3 h-48 rounded-t" />
-                <div class="px-2">
-                    <div class="text-base font-medium">@{{ item.name }}</div>
-                    @if (!Rapidez::config('catalog/frontend/show_swatches_in_product_list', 1))
-                        <div class="flex items-center space-x-2">
-                            <div class="font-semibold">@{{ (item.special_price || item.price) | price }}</div>
-                            <div class="text-sm line-through" v-if="item.special_price">@{{ item.price | price }}</div>
-                        </div>
-                    @endif
-                </div>
-            </a>
-            @includeWhen(Rapidez::config('catalog/frontend/show_swatches_in_product_list', 1), 'rapidez::listing.partials.item.addtocart')
-        </div>
+        <add-to-cart v-bind:product="item" v-slot="addToCart" v-cloak>
+            <div class="group relative flex flex-1 flex-col rounded border bg-white p-5" :key="item.entity_id">
+                @if (App::providerIsLoaded('Rapidez\Wishlist\WishlistServiceProvider'))
+                    <div class="group absolute right-0 top-0 z-10 p-2">
+                        @include('rapidez::wishlist.button')
+                    </div>
+                @endif
+                <a :href="item.url | url" class="block">
+                    <img
+                        v-if="addToCart.currentThumbnail"
+                        :src="'/storage/{{ config('rapidez.store') }}/resizes/200/magento/catalog/product' + addToCart.currentThumbnail + '.webp'"
+                        class="mb-3 h-48 w-full rounded-t object-contain" :alt="item.name" :loading="config.category && count <= 4 ? 'eager' : 'lazy'"
+                        width="200"
+                        height="200"
+                    />
+                    <x-rapidez::no-image v-else class="mb-3 h-48 rounded-t" />
+                    <div class="px-2">
+                        <div class="text-base font-medium">@{{ item.name }}</div>
+                        @if (!Rapidez::config('catalog/frontend/show_swatches_in_product_list', 1))
+                            <div class="flex items-center space-x-2">
+                                <div class="font-semibold">@{{ (item.special_price || item.price) | price }}</div>
+                                <div class="text-sm line-through" v-if="item.special_price">@{{ item.price | price }}</div>
+                            </div>
+                        @endif
+                    </div>
+                </a>
+                @include('rapidez::listing.partials.item.addtocart')
+            </div>
+        </add-to-cart>
     </div>
 </template>
diff --git a/resources/views/listing/partials/item/addtocart.blade.php b/resources/views/listing/partials/item/addtocart.blade.php
index ad53e05b..1574e74d 100644
--- a/resources/views/listing/partials/item/addtocart.blade.php
+++ b/resources/views/listing/partials/item/addtocart.blade.php
@@ -1,21 +1,19 @@
-<add-to-cart v-bind:product="item" v-slot="addToCart" v-cloak>
-    <form class="px-2 pb-2" v-on:submit.prevent="addToCart.add">
-        <div class="flex items-center space-x-2 mb-2">
-            <div class="font-semibold">
-                @{{ (addToCart.simpleProduct.special_price || addToCart.simpleProduct.price) | price }}
-            </div>
-            <div class="line-through text-sm" v-if="addToCart.simpleProduct.special_price">
-                @{{ addToCart.simpleProduct.price | price }}
-            </div>
+<form class="px-2 pb-2" v-on:submit.prevent="addToCart.add">
+    <div class="flex items-center space-x-2 mb-2">
+        <div class="font-semibold">
+            @{{ (addToCart.simpleProduct.special_price || addToCart.simpleProduct.price) | price }}
         </div>
+        <div class="line-through text-sm" v-if="addToCart.simpleProduct.special_price">
+            @{{ addToCart.simpleProduct.price | price }}
+        </div>
+    </div>
 
-        <p v-if="!item.in_stock" class="text-red-600 text-xs">
-            @lang('Sorry! This product is currently out of stock.')
-        </p>
-        <div v-else>
-            @include('rapidez::listing.partials.item.super_attributes')
+    <p v-if="!item.in_stock" class="text-red-600 text-xs">
+        @lang('Sorry! This product is currently out of stock.')
+    </p>
+    <div v-else>
+        @includeWhen(Rapidez::config('catalog/frontend/show_swatches_in_product_list', 1), 'rapidez::listing.partials.item.super_attributes')
 
-            <x-rapidez::button.cart/>
-        </div>
-    </form>
-</add-to-cart>
+        <x-rapidez::button.cart/>
+    </div>
+</form>

From 5c6b8944873492f77820f953acffb0d3fed1efb7 Mon Sep 17 00:00:00 2001
From: Jade-GG <Jade-GG@users.noreply.github.com>
Date: Thu, 9 Jan 2025 14:10:17 +0000
Subject: [PATCH 3/3] Apply fixes from Prettier

---
 resources/js/components/Product/AddToCart.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/resources/js/components/Product/AddToCart.vue b/resources/js/components/Product/AddToCart.vue
index e8f6e7fc..9534d40c 100644
--- a/resources/js/components/Product/AddToCart.vue
+++ b/resources/js/components/Product/AddToCart.vue
@@ -258,7 +258,7 @@ export default {
     },
 
     computed: {
-        currentThumbnail: function() {
+        currentThumbnail: function () {
             return this.simpleProduct?.thumbnail || this.simpleProduct?.images?.[0] || this.product?.thumbnail
         },