Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Accept RAFT handle everywhere #815

Closed
1 of 2 tasks
afender opened this issue Apr 6, 2020 · 2 comments
Closed
1 of 2 tasks

[FEA] Accept RAFT handle everywhere #815

afender opened this issue Apr 6, 2020 · 2 comments
Assignees
Milestone

Comments

@afender
Copy link
Member

afender commented Apr 6, 2020

Context
There are many reasons why we may want a handle :

  • communicator
  • Keep track of library wide events (status)
  • Counters (devices, streams, calls, … )
  • Stream(s)
  • Allocator
  • Cuda library handles (expensive to create)

Todo:

  • All multi-GPU should accept the handle from the beginning. It becomes pretty much required in the OPG paradigm. We need to pass the communicator so that we have a constant view of the multi-GPU / multi-process context.
  • All single GPU C++ API should be upgraded to accept the handle.
@afender afender added cuda ? - Needs Triage Need team to review and classify labels Apr 6, 2020
@BradReesWork BradReesWork removed the ? - Needs Triage Need team to review and classify label Apr 13, 2020
@BradReesWork BradReesWork added this to the 0.15 milestone Apr 13, 2020
This was referenced May 26, 2020
@afender
Copy link
Member Author

afender commented May 28, 2020

the handle is now in RAFT : rapidsai/raft#3

@afender afender changed the title [FEA] C++ cuGraph library handle [FEA] Accept RAFT handle everywhere Jun 24, 2020
@afender afender removed OPG labels Jun 24, 2020
@afender
Copy link
Member Author

afender commented Jul 1, 2020

The graph class has been updated and multi-GPU functions accept the handle.
We now need a consistent solution so that the handle content can be accessed from every feature.

Some of the challenges are:

  • avoid undefined behavior when the graph has a different handle than the algo
  • prevent recreating handle(s) as this can be costly

This task unblock stream support #957

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants