From 8f072a645842a0d16d38a525eb70ee04c3fb19e7 Mon Sep 17 00:00:00 2001 From: Vyas Ramasubramani Date: Tue, 21 Feb 2023 14:36:16 -0800 Subject: [PATCH 1/2] Add dfg as a pre-commit hook. --- .github/workflows/pr.yaml | 2 ++ .pre-commit-config.yaml | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/.github/workflows/pr.yaml b/.github/workflows/pr.yaml index 5bb34e9882..33e43b9353 100644 --- a/.github/workflows/pr.yaml +++ b/.github/workflows/pr.yaml @@ -27,6 +27,8 @@ jobs: checks: secrets: inherit uses: rapidsai/shared-action-workflows/.github/workflows/checks.yaml@branch-23.04 + with: + enable_check_generated_files: false conda-cpp-build: needs: checks secrets: inherit diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index e80c0b6a76..92ecbf399e 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -53,6 +53,10 @@ repos: - cpp/test pass_filenames: false language: python + - repo: https://github.com/rapidsai/dependency-file-generator + rev: v1.2.0 + hooks: + - id: rapids-dependency-file-generator default_language_version: python: python3 From fb39509a751b260b4aeaca1840332ebf38441780 Mon Sep 17 00:00:00 2001 From: Vyas Ramasubramani Date: Thu, 23 Feb 2023 15:44:06 -0800 Subject: [PATCH 2/2] Apply suggestions from code review --- .pre-commit-config.yaml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 92ecbf399e..4202e88da8 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -54,9 +54,10 @@ repos: pass_filenames: false language: python - repo: https://github.com/rapidsai/dependency-file-generator - rev: v1.2.0 + rev: v1.4.0 hooks: - id: rapids-dependency-file-generator + args: ["--clean"] default_language_version: python: python3