Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always use a static gtest and gbench #2265

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Always use a static gtest and gbench #2265

merged 2 commits into from
Apr 16, 2024

Conversation

robertmaynard
Copy link
Contributor

Removes the need for us to install GTest or GBench in our raft testing CI

@robertmaynard robertmaynard added feature request New feature or request non-breaking Non-breaking change labels Apr 15, 2024
@robertmaynard robertmaynard requested review from a team as code owners April 15, 2024 13:26
bdice
bdice approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you cross-link to a central issue for these PRs to help with tracking?

@robertmaynard robertmaynard mentioned this pull request Apr 15, 2024
Closed
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 39f3854 into rapidsai:branch-24.06 Apr 16, 2024
69 checks passed
@robertmaynard robertmaynard deleted the fea/static_test_dependencies branch April 16, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AyodeAwe AyodeAwe AyodeAwe approved these changes

@bdice bdice bdice approved these changes

Assignees
No one assigned
Labels
CMake cpp feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertmaynard @bdice @AyodeAwe