Hiding implementation details for random, stats, and matrix #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyegala
added
2 - In Progress
divyegala
added
3 - Ready for Review
and removed
2 - In Progress
cjnolet
requested changes
Oct 6, 2021
…imp-21.12-detail_refactor
cjnolet
approved these changes
Oct 21, 2021
| d_in[idx] = -d_in[idx]; | ||
| } | ||
| } | ||
| detail::argmax(in, n_rows, n_cols, out, stream); |
|
@divyegala looks like this got a tad out of date w/ the merge of the distances public API |
dantegd
requested changes
Nov 9, 2021
| @@ -0,0 +1,376 @@ | |||
| /* | |||
There was a problem hiding this comment.
cugraph uses rng.cuh in a couple of places, so leaving a quick review so we don’t merge this before that side is ready (if it already is, just let me know and glad to approve/merge)
dantegd
approved these changes
Nov 11, 2021
|
@gpucibot merge |
rapids-bot bot
pushed a commit
to rapidsai/cuml
that referenced
this pull request
Nov 12, 2021
…ons in detail (#4294) Depends on rapidsai/raft#356 Authors: - Divye Gala (https://github.com/divyegala) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - Dante Gama Dessavre (https://github.com/dantegd) - Jordan Jacobelli (https://github.com/Ethyling) URL: #4294
rapids-bot bot
pushed a commit
to rapidsai/cugraph
that referenced
this pull request
Nov 12, 2021
Depends on rapidsai/raft#356 Authors: - Divye Gala (https://github.com/divyegala) Approvers: - Rick Ratzel (https://github.com/rlratzel) - Chuck Hastings (https://github.com/ChuckHastings) - Seunghwa Kang (https://github.com/seunghwak) URL: #1937
vimarsh6739
pushed a commit
to vimarsh6739/cuml
that referenced
this pull request
Oct 9, 2023
…ons in detail (rapidsai#4294) Depends on rapidsai/raft#356 Authors: - Divye Gala (https://github.com/divyegala) Approvers: - Corey J. Nolet (https://github.com/cjnolet) - Dante Gama Dessavre (https://github.com/dantegd) - Jordan Jacobelli (https://github.com/Ethyling) URL: rapidsai#4294
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.