Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make generated find module targets global #340

Merged

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jan 11, 2023

Description

The targets created by the generated find modules should be made visible to all executing CMake.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

vyasr added 2 commits January 11, 2023 10:22
… construction.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@vyasr vyasr added improvement Improves an existing functionality non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Jan 11, 2023
@vyasr vyasr self-assigned this Jan 11, 2023
@vyasr vyasr requested a review from a team as a code owner January 11, 2023 18:41
@robertmaynard
Copy link
Contributor

/merge

@robertmaynard
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 3801ee1 into rapidsai:branch-23.02 Jan 11, 2023
@vyasr vyasr deleted the fix/make_find_module_targets_global branch January 11, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants