Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CUDA compiler if available for generate_resource_spec #561

Merged

Conversation

KyleFromNVIDIA
Copy link
Contributor

Description

This ensures consistent detection of CUDAToolkit between the main project and the try_compile().

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
neo1973 Markus Härer
This ensures consistent detection of CUDAToolkit between the main
project and the try_compile().
@KyleFromNVIDIA KyleFromNVIDIA requested a review from a team as a code owner March 15, 2024 14:00
@KyleFromNVIDIA KyleFromNVIDIA added bug Something isn't working non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Mar 15, 2024
@KyleFromNVIDIA
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit a653913 into rapidsai:branch-24.04 Mar 18, 2024
15 checks passed
@trxcllnt
Copy link
Contributor

trxcllnt commented Mar 18, 2024

Seems like this might have exposed an issue in conda builds? https://github.com/rapidsai/devcontainers/actions/runs/8330706353/job/22795983353?pr=249#step:7:8045

@KyleFromNVIDIA
Copy link
Contributor Author

#564 fixed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants