Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logger hash #738

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Jan 6, 2025

Description

Updates rapids-logger to pick up rapidsai/rapids-logger#8.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
neo1973 Markus Härer
@vyasr vyasr added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Jan 6, 2025
@vyasr vyasr self-assigned this Jan 6, 2025
@vyasr vyasr added feature request New feature or request and removed improvement Improves an existing functionality labels Jan 6, 2025
@vyasr vyasr marked this pull request as ready for review January 6, 2025 19:50
@vyasr vyasr requested a review from a team as a code owner January 6, 2025 19:50
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, just make sure to change back to rapidsai once rapidsai/rapids-logger#8 is merged. I don't need to review again.

@vyasr
Copy link
Contributor Author

vyasr commented Jan 6, 2025

Approved, just make sure to change back to rapidsai once rapidsai/rapids-logger#8 is merged. I don't need to review again.

Done.

@vyasr
Copy link
Contributor Author

vyasr commented Jan 6, 2025

/merge

@rapids-bot rapids-bot bot merged commit ab8cd16 into rapidsai:branch-25.02 Jan 6, 2025
15 checks passed
@vyasr vyasr deleted the chore/update_rapids_logger branch January 6, 2025 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants