Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove management of UCX system libraries in build scripts #1053

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Jul 1, 2024

For rapidsai/build-planning#57, #1041 switched ucx-py over to libucx wheels. To test that that was working, it added some code to building scripts to remove system installations of UCX libraries.

That should no longer be necessary as of rapidsai/ci-imgs#154.

This proposes removing that code for managing system dependencies of UCX libraries, to simplify those build scripts a bit.

@jameslamb jameslamb changed the title WIP: remove management of UCX system libraries in build scripts remove management of UCX system libraries in build scripts Jul 1, 2024
@jameslamb jameslamb marked this pull request as ready for review July 1, 2024 19:51
@jameslamb jameslamb requested a review from a team as a code owner July 1, 2024 19:51
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 23169ca into rapidsai:branch-0.39 Jul 1, 2024
39 checks passed
@jameslamb jameslamb deleted the ucx-dirs branch July 1, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants