Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rapidsai/docker to nightly pipeline #29

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

raydouglass
Copy link
Member

Adds rapidsai/docker to the nightly pipeline.

This implementation differs from other repositories because the docker repo workflows combine build & test in a single workflow due to using temporary images during testing. I think a future enhancement should be to refactor the docker workflows to allow for split builds and tests which would be more flexible.

Depends on rapidsai/docker#565

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This will be nice to have an updated status on the docker builds.

@raydouglass
Copy link
Member Author

Filed an issue for the refactoring: rapidsai/docker#566

@raydouglass raydouglass marked this pull request as ready for review August 4, 2023 16:40
@raydouglass raydouglass requested a review from a team as a code owner August 4, 2023 16:40
@raydouglass raydouglass merged commit 3ccbb0e into rapidsai:main Aug 4, 2023
@raydouglass raydouglass deleted the add-docker-nightly branch August 4, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants