Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding lunar coords #164

Merged
merged 15 commits into from
Jan 24, 2025
Merged

Adding lunar coords #164

merged 15 commits into from
Jan 24, 2025

Conversation

wps2n
Copy link
Collaborator

@wps2n wps2n commented Jan 9, 2025

Adds compatibility with lunar based observatories using a new keyword world to specify the earth or moon (defaults to earth). Also contains a z=30 theory model and zero foregrounds model.

Needs:
Better handling of time_per_day and lst_bin_size
Moon specific tests

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.69%. Comparing base (8b38f77) to head (a8faf92).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
+ Coverage   98.62%   98.69%   +0.06%     
==========================================
  Files          15       15              
  Lines        1089     1147      +58     
==========================================
+ Hits         1074     1132      +58     
  Misses         15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@steven-murray steven-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @wps2n, this is a really cool addition!

Please see my few notes on the implementation -- otherwise this is very nice indeed :-)

@wps2n
Copy link
Collaborator Author

wps2n commented Jan 22, 2025

@steven-murray I've implemented your suggestions and updated the tests for coverage. Note, I made two pushes. There's an odd error happening with lunarsky in one of the test suites that didn't happen in the first push but now is despite not making any changes to the specific test in the second push. I'll look into that but if you want to review the other changes I think we're nearly ready to merge.

Copy link
Contributor

@steven-murray steven-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @wps2n this looks great! Let's get those tests passing and I think this is good to go!

@wps2n wps2n marked this pull request as ready for review January 23, 2025 17:25
making clear in doc strings that a lunar day is 655.2 hours
@wps2n
Copy link
Collaborator Author

wps2n commented Jan 23, 2025

@steven-murray I passed the PR by Jonathan and made a couple final updates. I am not sure how you would prefer it be merged into main or if there's a couple more housekeeping steps in order. Let me know and I can send it through, or I suppose you can

@steven-murray steven-murray merged commit 0acdc45 into main Jan 24, 2025
27 checks passed
@steven-murray
Copy link
Contributor

Great! Thanks @wps2n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants