-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding lunar coords #164
Adding lunar coords #164
Conversation
Enable moon specific code with "world" keyword
For FarView
Also includes "ultra_optimistic" no foregrounds model and z=30 theory model. Need to make more user friendly
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #164 +/- ##
==========================================
+ Coverage 98.62% 98.69% +0.06%
==========================================
Files 15 15
Lines 1089 1147 +58
==========================================
+ Hits 1074 1132 +58
Misses 15 15 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much @wps2n, this is a really cool addition!
Please see my few notes on the implementation -- otherwise this is very nice indeed :-)
@steven-murray I've implemented your suggestions and updated the tests for coverage. Note, I made two pushes. There's an odd error happening with lunarsky in one of the test suites that didn't happen in the first push but now is despite not making any changes to the specific test in the second push. I'll look into that but if you want to review the other changes I think we're nearly ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wps2n this looks great! Let's get those tests passing and I think this is good to go!
making clear in doc strings that a lunar day is 655.2 hours
@steven-murray I passed the PR by Jonathan and made a couple final updates. I am not sure how you would prefer it be merged into main or if there's a couple more housekeeping steps in order. Let me know and I can send it through, or I suppose you can |
Great! Thanks @wps2n |
Adds compatibility with lunar based observatories using a new keyword
world
to specify the earth or moon (defaults to earth). Also contains a z=30 theory model and zero foregrounds model.Needs:
Better handling of
time_per_day
andlst_bin_size
Moon specific tests