Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial #17

Merged
merged 5 commits into from
Nov 26, 2019
Merged

Tutorial #17

merged 5 commits into from
Nov 26, 2019

Conversation

steven-murray
Copy link
Contributor

Adds a better CLI tutorial, and a few necessary fixes.

Fixes #12
Fixes #15
Fixes #14

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@codecov
Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #17 into master will decrease coverage by 0.04%.
The diff coverage is 96.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage    90.6%   90.56%   -0.05%     
==========================================
  Files          10       10              
  Lines         628      678      +50     
==========================================
+ Hits          569      614      +45     
- Misses         59       64       +5
Impacted Files Coverage Δ
py21cmsense/__init__.py 100% <100%> (ø) ⬆️
py21cmsense/observatory.py 82.91% <100%> (-0.32%) ⬇️
py21cmsense/antpos.py 86.36% <100%> (ø) ⬆️
py21cmsense/observation.py 94.04% <100%> (+0.29%) ⬆️
py21cmsense/cli.py 97.1% <88.23%> (-2.9%) ⬇️
py21cmsense/sensitivity.py 91.82% <95.74%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2777eb5...ef487ef. Read the comment docs.

@steven-murray steven-murray merged commit b8798a7 into master Nov 26, 2019
@steven-murray steven-murray deleted the tutorial branch November 26, 2019 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide an example tutorial for a non-hera array Format of gridded data CLI performance
1 participant