-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ci/GitHub actions #30
Conversation
using this |
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 91.02% 91.63% +0.60%
==========================================
Files 10 10
Lines 680 729 +49
==========================================
+ Hits 619 668 +49
Misses 61 61
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable, thanks Matt
Looks like pre-commit is having a lot of trouble on windows. but I can't find anything in tox to like conditionally not do pre-commit on windows, or how to fix this issue. |
@mkolopanis I would actually separate the pre-commit stuff from tox altogether -- make it a separate github action. |
So currently it is run by |
Yeah, I'd take the |
d1e1b3a
to
f71287b
Compare
Oh I changed the name to remove the reference to "Tox". Looks like you'll have to update the "required checks" since those will never run again. |
🎉 |
set up tests to also run on github actions.
closes #24
TODO: