Skip to content

[RayCluster] Enable Secret informer watch/list and remove unused RBAC verbs #4202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rueian merged 5 commits into from
Nov 19, 2025
Merged

[RayCluster] Enable Secret informer watch/list and remove unused RBAC verbs #4202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b8ff95c
Add authentication secret reconciliation support
Future-Outlier Nov 18, 2025
6478505
update
Future-Outlier Nov 18, 2025
23d2d00
update
Future-Outlier Nov 18, 2025
7cfa090
fix flaky test
Future-Outlier Nov 18, 2025
7f653e1
remove test fix
rueian Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions helm-chart/kuberay-operator/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,8 +177,6 @@ rules:
- create
- get
- list
- patch
- update
- watch
- apiGroups:
- ""
Expand Down
2 changes: 0 additions & 2 deletions ray-operator/config/rbac/role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,6 @@ rules:
- create
- get
- list
- patch
- update
- watch
- apiGroups:
- ""
Expand Down
5 changes: 3 additions & 2 deletions ray-operator/controllers/ray/raycluster_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ type RayClusterReconcilerOptions struct {
// +kubebuilder:rbac:groups=core,resources=pods,verbs=get;list;watch;create;update;patch;delete;deletecollection
// +kubebuilder:rbac:groups=core,resources=pods/status,verbs=get;list;watch;create;update;patch;delete
// +kubebuilder:rbac:groups=core,resources=pods/resize,verbs=patch
// +kubebuilder:rbac:groups=core,resources=secrets,verbs=get;list;watch;create;update;patch
// +kubebuilder:rbac:groups=core,resources=secrets,verbs=get;list;watch;create;
// +kubebuilder:rbac:groups=core,resources=services,verbs=get;list;watch;create;update;patch;delete
// +kubebuilder:rbac:groups=core,resources=services/status,verbs=get;update;patch
// +kubebuilder:rbac:groups=coordination.k8s.io,resources=leases,verbs=get;list;create;update
Expand Down Expand Up @@ -1446,7 +1446,8 @@ func (r *RayClusterReconciler) SetupWithManager(mgr ctrl.Manager, reconcileConcu
predicate.AnnotationChangedPredicate{},
))).
Owns(&corev1.Pod{}).
Owns(&corev1.Service{})
Owns(&corev1.Service{}).
Owns(&corev1.Secret{})
if r.options.BatchSchedulerManager != nil {
r.options.BatchSchedulerManager.ConfigureReconciler(b)
}
Expand Down
Loading