Skip to content

Commit 070310e

Browse files
committed
[core][telemetry/10] support custom gauge+counter+sum metrics
Signed-off-by: can <can@anyscale.com>
1 parent d112569 commit 070310e

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/ray/stats/tests/metric_with_open_telemetry_test.cc

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,12 +130,18 @@ TEST_F(MetricTest, TestCounterMetric) {
130130
ASSERT_TRUE(OpenTelemetryMetricRecorder::GetInstance().IsMetricRegistered(
131131
"metric_counter_test"));
132132
STATS_metric_counter_test.Record(100.0, {{"Tag1", "Value1"}, {"Tag2", "Value2"}});
133+
LegacyMetricCounterTest.Record(100.0, {{"Tag1"sv, "Value1"}, {"Tag2"sv, "Value2"}});
134+
ASSERT_TRUE(OpenTelemetryMetricRecorder::GetInstance().IsMetricRegistered(
135+
"legacy_metric_counter_test"));
133136
}
134137

135138
TEST_F(MetricTest, TestSumMetric) {
136139
ASSERT_TRUE(
137140
OpenTelemetryMetricRecorder::GetInstance().IsMetricRegistered("metric_sum_test"));
138141
STATS_metric_sum_test.Record(200.0, {{"Tag1", "Value1"}, {"Tag2", "Value2"}});
142+
LegacyMetricSumTest.Record(200.0, {{"Tag1"sv, "Value1"}, {"Tag2"sv, "Value2"}});
143+
ASSERT_TRUE(OpenTelemetryMetricRecorder::GetInstance().IsMetricRegistered(
144+
"legacy_metric_sum_test"));
139145
}
140146

141147
} // namespace telemetry

0 commit comments

Comments
 (0)