Skip to content

Conversation

@richardliaw
Copy link
Contributor

filemount: {"x" : "~/directory/"} currently does not work because the path isn't expanded.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Ray-PRB/6592/
Test PASSed.

@ericl
Copy link
Contributor

ericl commented Jul 10, 2018

It's not correct to expand on the client side I believe, since the server home dir may be different. Cc @hartikainen

@richardliaw
Copy link
Contributor Author

richardliaw commented Jul 11, 2018 via email

@ericl
Copy link
Contributor

ericl commented Jul 11, 2018

Hm I see, this is the read side path expansion only, so it looks fine. The mount point is resolved on the server side only.

@richardliaw richardliaw merged commit 5188b1d into ray-project:master Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants