Fix typing for explore argument
#30734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ram Rachum <ram@rachum.com>
cool-RR
requested review from
sven1977,
gjoliver,
avnishn,
ArturNiederfahrenhorst,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
stale
bot
added
the
stale
|
Too bad no one found time to review this.
…On Sat, Dec 31, 2022 at 9:36 PM stale[bot] ***@***.***> wrote:
This pull request has been automatically marked as stale because it has
not had recent activity. It will be closed in 14 days if no further
activity occurs. Thank you for your contributions.
- If you'd like to keep this open, just leave any comment, and the
stale label will be removed.
—
Reply to this email directly, view it on GitHub
<#30734 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAN3SX3MLRBOLN4NELRSTLWQCDKXANCNFSM6AAAAAASOOR7FY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
stale
bot
removed
the
stale
richardliaw
approved these changes
Jan 1, 2023
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
stale
bot
added
the
stale
|
I hope that this PR will be reviewed. |
richardliaw
approved these changes
Feb 2, 2023
richardliaw
removed
the
stale
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
Signed-off-by: Ram Rachum <ram@rachum.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ram Rachum ram@rachum.com
Since the
exploreargument can accept the valueNone, it can't be justbool. I fixed it toOptional[bool].