From 87611d0725bd6b657300ed9023b9827b561b793d Mon Sep 17 00:00:00 2001 From: Artur Niederfahrenhorst Date: Mon, 23 Jan 2023 23:37:37 -0800 Subject: [PATCH 1/2] make torch test longer Signed-off-by: Artur Niederfahrenhorst --- release/release_tests.yaml | 4 +- .../ppo-breakoutnoframeskip-v5-tf.yaml} | 1 + .../ppo-breakoutnoframeskip-v5-torch.yaml | 37 +++++++++++++++++++ 3 files changed, 40 insertions(+), 2 deletions(-) rename release/rllib_tests/learning_tests/yaml_files/ppo/{ppo-breakoutnoframeskip-v5.yaml => tf/ppo-breakoutnoframeskip-v5-tf.yaml} (98%) create mode 100644 release/rllib_tests/learning_tests/yaml_files/ppo/torch/ppo-breakoutnoframeskip-v5-torch.yaml diff --git a/release/release_tests.yaml b/release/release_tests.yaml index 879cd0132ef0..7ec2d8a64268 100644 --- a/release/release_tests.yaml +++ b/release/release_tests.yaml @@ -3174,7 +3174,7 @@ run: timeout: 18000 - script: python learning_tests/run.py --yaml-sub-dir=ppo --framework=tf + script: python learning_tests/run.py --yaml-sub-dir=ppo/tf --framework=tf alert: default @@ -3197,7 +3197,7 @@ run: timeout: 18000 - script: python learning_tests/run.py --yaml-sub-dir=ppo --framework=torch + script: python learning_tests/run.py --yaml-sub-dir=ppo/torch --framework=torch alert: default diff --git a/release/rllib_tests/learning_tests/yaml_files/ppo/ppo-breakoutnoframeskip-v5.yaml b/release/rllib_tests/learning_tests/yaml_files/ppo/tf/ppo-breakoutnoframeskip-v5-tf.yaml similarity index 98% rename from release/rllib_tests/learning_tests/yaml_files/ppo/ppo-breakoutnoframeskip-v5.yaml rename to release/rllib_tests/learning_tests/yaml_files/ppo/tf/ppo-breakoutnoframeskip-v5-tf.yaml index c3d88cc9513d..1b927106d138 100644 --- a/release/rllib_tests/learning_tests/yaml_files/ppo/ppo-breakoutnoframeskip-v5.yaml +++ b/release/rllib_tests/learning_tests/yaml_files/ppo/tf/ppo-breakoutnoframeskip-v5-tf.yaml @@ -7,6 +7,7 @@ ppo-breakoutnoframeskip-v5: timesteps_total: 7000000 stop: time_total_s: 3600 + num_samples: 10 config: # Make analogous to old v4 + NoFrameskip. env_config: diff --git a/release/rllib_tests/learning_tests/yaml_files/ppo/torch/ppo-breakoutnoframeskip-v5-torch.yaml b/release/rllib_tests/learning_tests/yaml_files/ppo/torch/ppo-breakoutnoframeskip-v5-torch.yaml new file mode 100644 index 000000000000..0d1ad9ed1d25 --- /dev/null +++ b/release/rllib_tests/learning_tests/yaml_files/ppo/torch/ppo-breakoutnoframeskip-v5-torch.yaml @@ -0,0 +1,37 @@ +ppo-breakoutnoframeskip-v5: + env: ALE/Breakout-v5 + run: PPO + # Minimum reward and total ts (in given time_total_s) to pass this test. + pass_criteria: + episode_reward_mean: 50.0 + timesteps_total: 7000000 + stop: + # This is double the time we use for tf because of 2x throughput there. + time_total_s: 7200 + num_samples: 10 + config: + # Make analogous to old v4 + NoFrameskip. + env_config: + frameskip: 1 + full_action_space: false + repeat_action_probability: 0.0 + lambda: 0.95 + kl_coeff: 0.5 + clip_rewards: True + clip_param: 0.1 + vf_clip_param: 10.0 + entropy_coeff: 0.01 + train_batch_size: 5000 + rollout_fragment_length: auto + sgd_minibatch_size: 500 + num_sgd_iter: 10 + num_workers: 30 + num_envs_per_worker: 1 + batch_mode: truncate_episodes + observation_filter: NoFilter + model: + vf_share_layers: true + num_gpus: 2 + min_time_s_per_iteration: 30 + lr: 0.0001 + grad_clip: 100 From 766c7bf1c67e317cac86a1d7d80301a5d2bbd049 Mon Sep 17 00:00:00 2001 From: Artur Niederfahrenhorst Date: Tue, 24 Jan 2023 11:52:31 -0800 Subject: [PATCH 2/2] remove num_samples Signed-off-by: Artur Niederfahrenhorst --- .../yaml_files/ppo/tf/ppo-breakoutnoframeskip-v5-tf.yaml | 1 - .../yaml_files/ppo/torch/ppo-breakoutnoframeskip-v5-torch.yaml | 1 - 2 files changed, 2 deletions(-) diff --git a/release/rllib_tests/learning_tests/yaml_files/ppo/tf/ppo-breakoutnoframeskip-v5-tf.yaml b/release/rllib_tests/learning_tests/yaml_files/ppo/tf/ppo-breakoutnoframeskip-v5-tf.yaml index 1b927106d138..c3d88cc9513d 100644 --- a/release/rllib_tests/learning_tests/yaml_files/ppo/tf/ppo-breakoutnoframeskip-v5-tf.yaml +++ b/release/rllib_tests/learning_tests/yaml_files/ppo/tf/ppo-breakoutnoframeskip-v5-tf.yaml @@ -7,7 +7,6 @@ ppo-breakoutnoframeskip-v5: timesteps_total: 7000000 stop: time_total_s: 3600 - num_samples: 10 config: # Make analogous to old v4 + NoFrameskip. env_config: diff --git a/release/rllib_tests/learning_tests/yaml_files/ppo/torch/ppo-breakoutnoframeskip-v5-torch.yaml b/release/rllib_tests/learning_tests/yaml_files/ppo/torch/ppo-breakoutnoframeskip-v5-torch.yaml index 0d1ad9ed1d25..3241d39d37ab 100644 --- a/release/rllib_tests/learning_tests/yaml_files/ppo/torch/ppo-breakoutnoframeskip-v5-torch.yaml +++ b/release/rllib_tests/learning_tests/yaml_files/ppo/torch/ppo-breakoutnoframeskip-v5-torch.yaml @@ -8,7 +8,6 @@ ppo-breakoutnoframeskip-v5: stop: # This is double the time we use for tf because of 2x throughput there. time_total_s: 7200 - num_samples: 10 config: # Make analogous to old v4 + NoFrameskip. env_config: