From 154d250aa528091a134abb6cb45ba7f651d20a6f Mon Sep 17 00:00:00 2001 From: Artur Niederfahrenhorst Date: Tue, 24 Jan 2023 15:28:09 -0800 Subject: [PATCH 1/3] give more time to impala tests Signed-off-by: Artur Niederfahrenhorst --- .../impala-breakoutnoframeskip-v5-tf.yaml} | 7 ++---- .../impala-breakoutnoframeskip-v5-torch.yaml | 22 +++++++++++++++++++ 2 files changed, 24 insertions(+), 5 deletions(-) rename release/rllib_tests/learning_tests/yaml_files/impala/{impala-breakoutnoframeskip-v5.yaml => tf/impala-breakoutnoframeskip-v5-tf.yaml} (82%) create mode 100644 release/rllib_tests/learning_tests/yaml_files/impala/torch/impala-breakoutnoframeskip-v5-torch.yaml diff --git a/release/rllib_tests/learning_tests/yaml_files/impala/impala-breakoutnoframeskip-v5.yaml b/release/rllib_tests/learning_tests/yaml_files/impala/tf/impala-breakoutnoframeskip-v5-tf.yaml similarity index 82% rename from release/rllib_tests/learning_tests/yaml_files/impala/impala-breakoutnoframeskip-v5.yaml rename to release/rllib_tests/learning_tests/yaml_files/impala/tf/impala-breakoutnoframeskip-v5-tf.yaml index bc81412d94ce..e0d054164cb4 100644 --- a/release/rllib_tests/learning_tests/yaml_files/impala/impala-breakoutnoframeskip-v5.yaml +++ b/release/rllib_tests/learning_tests/yaml_files/impala/tf/impala-breakoutnoframeskip-v5-tf.yaml @@ -6,7 +6,7 @@ impala-breakoutnoframeskip-v5: episode_reward_mean: 200.0 timesteps_total: 6000000 stop: - time_total_s: 1800 + time_total_s: 2400 config: # Make analogous to old v4 + NoFrameskip. env_config: @@ -18,8 +18,5 @@ impala-breakoutnoframeskip-v5: num_workers: 10 num_envs_per_worker: 5 clip_rewards: True - lr_schedule: [ - [0, 0.0005], - [20000000, 0.000000000001], - ] + lr: 0.0005 num_gpus: 1 diff --git a/release/rllib_tests/learning_tests/yaml_files/impala/torch/impala-breakoutnoframeskip-v5-torch.yaml b/release/rllib_tests/learning_tests/yaml_files/impala/torch/impala-breakoutnoframeskip-v5-torch.yaml new file mode 100644 index 000000000000..e0d054164cb4 --- /dev/null +++ b/release/rllib_tests/learning_tests/yaml_files/impala/torch/impala-breakoutnoframeskip-v5-torch.yaml @@ -0,0 +1,22 @@ +impala-breakoutnoframeskip-v5: + env: ALE/Breakout-v5 + run: IMPALA + # Minimum reward and total ts (in given time_total_s) to pass this test. + pass_criteria: + episode_reward_mean: 200.0 + timesteps_total: 6000000 + stop: + time_total_s: 2400 + config: + # Make analogous to old v4 + NoFrameskip. + env_config: + frameskip: 1 + full_action_space: false + repeat_action_probability: 0.0 + rollout_fragment_length: 50 + train_batch_size: 500 + num_workers: 10 + num_envs_per_worker: 5 + clip_rewards: True + lr: 0.0005 + num_gpus: 1 From 39916a862358e3d6df26754aa6b33052d9c695cb Mon Sep 17 00:00:00 2001 From: Artur Niederfahrenhorst Date: Tue, 24 Jan 2023 15:36:07 -0800 Subject: [PATCH 2/3] change config Signed-off-by: Artur Niederfahrenhorst --- .../impala/impala-breakoutnoframeskip-v5.yaml | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+) create mode 100644 release/rllib_tests/learning_tests/yaml_files/impala/impala-breakoutnoframeskip-v5.yaml diff --git a/release/rllib_tests/learning_tests/yaml_files/impala/impala-breakoutnoframeskip-v5.yaml b/release/rllib_tests/learning_tests/yaml_files/impala/impala-breakoutnoframeskip-v5.yaml new file mode 100644 index 000000000000..e0d054164cb4 --- /dev/null +++ b/release/rllib_tests/learning_tests/yaml_files/impala/impala-breakoutnoframeskip-v5.yaml @@ -0,0 +1,22 @@ +impala-breakoutnoframeskip-v5: + env: ALE/Breakout-v5 + run: IMPALA + # Minimum reward and total ts (in given time_total_s) to pass this test. + pass_criteria: + episode_reward_mean: 200.0 + timesteps_total: 6000000 + stop: + time_total_s: 2400 + config: + # Make analogous to old v4 + NoFrameskip. + env_config: + frameskip: 1 + full_action_space: false + repeat_action_probability: 0.0 + rollout_fragment_length: 50 + train_batch_size: 500 + num_workers: 10 + num_envs_per_worker: 5 + clip_rewards: True + lr: 0.0005 + num_gpus: 1 From 69747de127f05166b2beaf6905ef713ca47cf527 Mon Sep 17 00:00:00 2001 From: Artur Niederfahrenhorst Date: Tue, 24 Jan 2023 15:36:49 -0800 Subject: [PATCH 3/3] remove old configs Signed-off-by: Artur Niederfahrenhorst --- .../tf/impala-breakoutnoframeskip-v5-tf.yaml | 22 ------------------- .../impala-breakoutnoframeskip-v5-torch.yaml | 22 ------------------- 2 files changed, 44 deletions(-) delete mode 100644 release/rllib_tests/learning_tests/yaml_files/impala/tf/impala-breakoutnoframeskip-v5-tf.yaml delete mode 100644 release/rllib_tests/learning_tests/yaml_files/impala/torch/impala-breakoutnoframeskip-v5-torch.yaml diff --git a/release/rllib_tests/learning_tests/yaml_files/impala/tf/impala-breakoutnoframeskip-v5-tf.yaml b/release/rllib_tests/learning_tests/yaml_files/impala/tf/impala-breakoutnoframeskip-v5-tf.yaml deleted file mode 100644 index e0d054164cb4..000000000000 --- a/release/rllib_tests/learning_tests/yaml_files/impala/tf/impala-breakoutnoframeskip-v5-tf.yaml +++ /dev/null @@ -1,22 +0,0 @@ -impala-breakoutnoframeskip-v5: - env: ALE/Breakout-v5 - run: IMPALA - # Minimum reward and total ts (in given time_total_s) to pass this test. - pass_criteria: - episode_reward_mean: 200.0 - timesteps_total: 6000000 - stop: - time_total_s: 2400 - config: - # Make analogous to old v4 + NoFrameskip. - env_config: - frameskip: 1 - full_action_space: false - repeat_action_probability: 0.0 - rollout_fragment_length: 50 - train_batch_size: 500 - num_workers: 10 - num_envs_per_worker: 5 - clip_rewards: True - lr: 0.0005 - num_gpus: 1 diff --git a/release/rllib_tests/learning_tests/yaml_files/impala/torch/impala-breakoutnoframeskip-v5-torch.yaml b/release/rllib_tests/learning_tests/yaml_files/impala/torch/impala-breakoutnoframeskip-v5-torch.yaml deleted file mode 100644 index e0d054164cb4..000000000000 --- a/release/rllib_tests/learning_tests/yaml_files/impala/torch/impala-breakoutnoframeskip-v5-torch.yaml +++ /dev/null @@ -1,22 +0,0 @@ -impala-breakoutnoframeskip-v5: - env: ALE/Breakout-v5 - run: IMPALA - # Minimum reward and total ts (in given time_total_s) to pass this test. - pass_criteria: - episode_reward_mean: 200.0 - timesteps_total: 6000000 - stop: - time_total_s: 2400 - config: - # Make analogous to old v4 + NoFrameskip. - env_config: - frameskip: 1 - full_action_space: false - repeat_action_probability: 0.0 - rollout_fragment_length: 50 - train_batch_size: 500 - num_workers: 10 - num_envs_per_worker: 5 - clip_rewards: True - lr: 0.0005 - num_gpus: 1