[Data] Add tests for remainder of map_batches operations with new optimizer
#31985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amogkam
requested review from
ericl,
scv119,
clarkzinzow,
jjyao,
jianoaix and
c21
as code owners
c21
approved these changes
Jan 27, 2023
| @@ -115,6 +115,37 @@ def test_flat_map_e2e(ray_start_cluster_enabled, enable_optimizer): | |||
| assert ds.take_all() == [0, 0, 1, 1], ds | |||
|
|
|||
|
|
|||
| def test_column_ops_e2e(ray_start_cluster_enabled, enable_optimizer): | |||
There was a problem hiding this comment.
could we also add test to check Already covered by op.name, isinstance(physical_op, MapOperator), etc as above?map_batches, so never mind.
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…imizer (ray-project#31985) Signed-off-by: amogkam <amogkamsetty@yahoo.com> The following operations call map_batches directly: add_column, drop_columns, select_columns, random_sample. In this PR we add e2e tests for these examples with the new optimizer. In a future PR, we should refactor so that these operations do not call into map_batches and instead have their own logical operator. Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: amogkam amogkamsetty@yahoo.com
The following operations call
map_batchesdirectly:add_column,drop_columns,select_columns,random_sample.In this PR we add e2e tests for these examples with the new optimizer. In a future PR, we should refactor so that these operations do not call into
map_batchesand instead have their own logical operator.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.