Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix linkcheck error and map batches docstring test #31996

Merged
merged 2 commits into from
Jan 27, 2023

Conversation

krfricke
Copy link
Contributor

Why are these changes needed?

581cd4e moved some test files, breaking a link from the documentation. cc @iycheng

3343c76 changed the MapBatches string representation, breaking a docstring test. cc @peytondmurray

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Kai Fricke added 2 commits January 27, 2023 08:44
Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Kai Fricke <kai@anyscale.com>
Copy link
Contributor

@peytondmurray peytondmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! 🚀

@krfricke krfricke merged commit 1b20ae9 into ray-project:master Jan 27, 2023
@krfricke krfricke deleted the linkcheck/many_nodes branch January 27, 2023 19:22
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
…t#31996)

581cd4e moved some test files, breaking a link from the documentation. cc @iycheng

3343c76 changed the MapBatches string representation, breaking a docstring test. cc @peytondmurray

Signed-off-by: Kai Fricke <kai@anyscale.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants