[Datasets] Refactor map-like functions into planner package #32021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cheng Su <scnju13@gmail.com>
c21
requested review from
ericl,
scv119,
clarkzinzow,
jjyao and
jianoaix
as code owners
c21
commented
Jan 28, 2023
| fn_args: Optional[Iterable[Any]] = None, | ||
| fn_kwargs: Optional[Dict[str, Any]] = None, | ||
| fn_constructor_args: Optional[Iterable[Any]] = None, | ||
| fn_constructor_kwargs: Optional[Dict[str, Any]] = None, | ||
| target_block_size: Optional[int] = None, |
There was a problem hiding this comment.
This is just reordering arguments, to make all fn-related arguments to be put together, and look more coherent.
c21
commented
Jan 28, 2023
| from ray.data.context import DatasetContext | ||
|
|
||
|
|
||
| def generate_filter_fn() -> Callable[[Iterator[Block]], Iterator[Block]]: |
There was a problem hiding this comment.
This is copied from Dataset.filter()
c21
commented
Jan 28, 2023
| from ray.data.context import DatasetContext | ||
|
|
||
|
|
||
| def generate_flat_map_fn() -> Callable[[Iterator[Block]], Iterator[Block]]: |
There was a problem hiding this comment.
This is copied from Dataset.flat_map()
c21
commented
Jan 28, 2023
| from typing_extensions import Literal | ||
|
|
||
|
|
||
| def generate_map_batches_fn( |
There was a problem hiding this comment.
This is copied from Dataset.map_batches()
c21
commented
Jan 28, 2023
| from ray.data.context import DatasetContext | ||
|
|
||
|
|
||
| def generate_map_rows_fn() -> Callable[[Iterator[Block]], Iterator[Block]]: |
There was a problem hiding this comment.
This is copied from Dataset.map()
ericl
approved these changes
Jan 28, 2023
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
Signed-off-by: Cheng Su <scnju13@gmail.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cheng Su scnju13@gmail.com
Why are these changes needed?
This PR is followup of #31977 (comment), to remove
block_fnfrom logical operator, and make planner to generate functions formap_batches/map/flat_map/filter. The change includesblock_fnfromAbstactMap, and all subclasses.transformfunctions defined inDataset.map_batches/map/flat_map/filterintoPlanner.generate_xxx_fn(e.g.generate_map_batches_fn)Decide to doing refactoring from
Datasethere, because we update those code paths very frequently (e.g.Dataset.map_batches()), so don't want to maintain two diverged code paths. Also different fromplan.pyandstage_impl.py, we won't deletedataset.py.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.