Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[core][state] Adjust worker side reporting with batches && add debugstring " #32024

Merged
merged 1 commit into from
Jan 28, 2023

Conversation

krfricke
Copy link
Contributor

Reverts #31840

This broke the mac builds

@rkooo567
Copy link
Contributor

https://buildkite.com/ray-project/oss-ci-build-branch/builds/2036#0185f5b7-0c5e-4739-8d7f-05dd56592afd

Screen Shot 2023-01-28 at 9 12 18 AM

Seems like the issue some minor compiler issue... let's revert it and make sure mac build passes (it is kind of surprising because I am sure @rickyyx wrote code in Mac)

@rkooo567 rkooo567 merged commit c889349 into master Jan 28, 2023
@rkooo567 rkooo567 deleted the revert-31840-TA-worker-side-batching branch January 28, 2023 17:13
@rickyyx
Copy link
Contributor

rickyyx commented Jan 30, 2023

Surprise - I worked on linux actually haha. Will do.

edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
…d debugstring (ray-project#31840)" (ray-project#32024)

This reverts commit 5d1f2e4.

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants