Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][core] Calculate actor creation time properly for stress_test_many_tasks #32438

Merged
merged 3 commits into from
Feb 13, 2023

Conversation

rickyyx
Copy link
Contributor

@rickyyx rickyyx commented Feb 10, 2023

Signed-off-by: rickyyx rickyx@anyscale.com

Why are these changes needed?

We are calculating actor creation task submission time, which is less useful for this test.

Related issue number

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: rickyyx <rickyx@anyscale.com>
Signed-off-by: rickyyx <rickyx@anyscale.com>
@rickyyx rickyyx changed the title try [core] Do not set flushing thread niceness Feb 10, 2023
@rickyyx rickyyx changed the title [core] Do not set flushing thread niceness [ci][core] Calculate actor creation time properly for stress_test_many_tasks Feb 10, 2023
@rickyyx rickyyx assigned scv119 and unassigned cadedaniel Feb 10, 2023
Signed-off-by: rickyyx <rickyx@anyscale.com>
@rickyyx rickyyx marked this pull request as ready for review February 10, 2023 21:08
@rickyyx
Copy link
Contributor Author

rickyyx commented Feb 10, 2023

Smoke tests on stress_test_many_task: https://buildkite.com/ray-project/release-tests-pr/builds/28108

@rkooo567 rkooo567 merged commit e56665e into ray-project:master Feb 13, 2023
edoakes pushed a commit to edoakes/ray that referenced this pull request Mar 22, 2023
…y_tasks (ray-project#32438)

Signed-off-by: rickyyx <rickyx@anyscale.com>

We are calculating actor creation task submission time, which is less useful for this test.

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants