Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] upgrade manylinux image #46361

Merged
merged 1 commit into from
Jul 1, 2024
Merged

[ci] upgrade manylinux image #46361

merged 1 commit into from
Jul 1, 2024

Conversation

can-anyscale
Copy link
Collaborator

Upgrade manylinux image to see if it fixes the mirrolist.centoos deprecated issue

Test:

  • CI

@aslonnie
Copy link
Collaborator

aslonnie commented Jul 1, 2024

does not seem to work:
https://buildkite.com/ray-project/microcheck/builds/2420#01906f7a-de3c-47fb-8932-2fdc3afa69c8/141-213

I think you need to change the mirror URL.

supposedly we should not be trying to install extra stuff into the image. we should only be using the image to build the wheel.

@can-anyscale can-anyscale force-pushed the can-manylinux branch 6 times, most recently from 646b76e to 4cf26dd Compare July 1, 2024 19:54
Signed-off-by: can <can@anyscale.com>
@can-anyscale can-anyscale marked this pull request as ready for review July 1, 2024 20:06
@can-anyscale can-anyscale requested a review from a team as a code owner July 1, 2024 20:06
@can-anyscale can-anyscale requested review from aslonnie and khluu July 1, 2024 20:06
@can-anyscale can-anyscale enabled auto-merge (squash) July 1, 2024 20:24
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jul 1, 2024
@can-anyscale can-anyscale merged commit db2288c into master Jul 1, 2024
7 of 8 checks passed
@can-anyscale can-anyscale deleted the can-manylinux branch July 1, 2024 22:47
votrou pushed a commit to pinterest/ray that referenced this pull request Jul 10, 2024
Upgrade manylinux image to see if it fixes the mirrolist.centoos
deprecated issue

Test:
- CI

Signed-off-by: can <can@anyscale.com>
votrou added a commit to pinterest/ray that referenced this pull request Jul 10, 2024
This PR is necessary to get the Ray pipeline to build images for us

Upgrade manylinux image to see if it fixes the mirrolist.centoos
deprecated issue

Test:
- CI

<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

<!-- Please give a short summary of the change and the problem this
solves. -->

## Related issue number

<!-- For example: "Closes ray-project#1234" -->

## Checks

- [ ] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: can <can@anyscale.com>
Co-authored-by: Cuong Nguyen <128072568+can-anyscale@users.noreply.github.com>
votrou added a commit to pinterest/ray that referenced this pull request Aug 20, 2024
sjoshi6 pushed a commit to pinterest/ray that referenced this pull request Oct 31, 2024
This PR is necessary to get the Ray pipeline to build images for us

Upgrade manylinux image to see if it fixes the mirrolist.centoos
deprecated issue

Test:
- CI

<!-- Thank you for your contribution! Please review
https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before
opening a pull request. -->

<!-- Please add a reviewer to the assignee section when you create a PR.
If you don't have the access to it, we will shortly find a reviewer and
assign them to your PR. -->

## Why are these changes needed?

<!-- Please give a short summary of the change and the problem this
solves. -->

## Related issue number

<!-- For example: "Closes ray-project#1234" -->

## Checks

- [ ] I've signed off every commit(by using the -s flag, i.e., `git
commit -s`) in this PR.
- [ ] I've run `scripts/format.sh` to lint the changes in this PR.
- [ ] I've included any doc changes needed for
https://docs.ray.io/en/master/.
- [ ] I've added any new APIs to the API Reference. For example, if I
added a
method in Tune, I've added it in `doc/source/tune/api/` under the
           corresponding `.rst` file.
- [ ] I've made sure the tests are passing. Note that there might be a
few flaky tests, see the recent failures at https://flakey-tests.ray.io/
- Testing Strategy
   - [ ] Unit tests
   - [ ] Release tests
   - [ ] This PR is not tested :(

Signed-off-by: can <can@anyscale.com>
Co-authored-by: Cuong Nguyen <128072568+can-anyscale@users.noreply.github.com>
Signed-off-by: Saurabh Vishwas Joshi <sjoshi@sjoshi-7534X5H.dyn.pinadmin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants