From 6444343e692d4bed4356673afeef0c77257ef70d Mon Sep 17 00:00:00 2001 From: Amog Kamsetty Date: Tue, 30 Jul 2024 15:23:06 -0700 Subject: [PATCH 1/3] clarify pg behavior in docs Signed-off-by: Amog Kamsetty --- doc/source/ray-core/scheduling/placement-group.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/doc/source/ray-core/scheduling/placement-group.rst b/doc/source/ray-core/scheduling/placement-group.rst index d78fbdcb88e4..7ef3d0d68194 100644 --- a/doc/source/ray-core/scheduling/placement-group.rst +++ b/doc/source/ray-core/scheduling/placement-group.rst @@ -577,6 +577,11 @@ child tasks and actors to the same placement group, specify ``PlacementGroupSche :start-after: __child_capture_disable_pg_start__ :end-before: __child_capture_disable_pg_end__ +.. warning:: + The value of ``placement_group_capture_child_tasks`` for a given actor is not inherited from its parent. If are creating nested actors of depth greater than 1 + that should all use the same placement group, ``placement_group_capture_child_tasks`` should be explicitly set for each actor. + + [Advanced] Named Placement Group -------------------------------- From 5da1041df02b5ba09596b80f83a2063dae3d9ca7 Mon Sep 17 00:00:00 2001 From: Amog Kamsetty Date: Tue, 30 Jul 2024 15:25:13 -0700 Subject: [PATCH 2/3] Update doc/source/ray-core/scheduling/placement-group.rst Signed-off-by: Amog Kamsetty --- doc/source/ray-core/scheduling/placement-group.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/source/ray-core/scheduling/placement-group.rst b/doc/source/ray-core/scheduling/placement-group.rst index 7ef3d0d68194..1b1b608d2a32 100644 --- a/doc/source/ray-core/scheduling/placement-group.rst +++ b/doc/source/ray-core/scheduling/placement-group.rst @@ -578,7 +578,7 @@ child tasks and actors to the same placement group, specify ``PlacementGroupSche :end-before: __child_capture_disable_pg_end__ .. warning:: - The value of ``placement_group_capture_child_tasks`` for a given actor is not inherited from its parent. If are creating nested actors of depth greater than 1 + The value of ``placement_group_capture_child_tasks`` for a given actor is not inherited from its parent. If you are creating nested actors of depth greater than 1 that should all use the same placement group, ``placement_group_capture_child_tasks`` should be explicitly set for each actor. From 9675a916f647cb1d84fdc8429acd19862da16e0d Mon Sep 17 00:00:00 2001 From: Jiajun Yao Date: Sun, 4 Aug 2024 23:38:31 -0700 Subject: [PATCH 3/3] Apply suggestions from code review Co-authored-by: angelinalg <122562471+angelinalg@users.noreply.github.com> Signed-off-by: Jiajun Yao --- doc/source/ray-core/scheduling/placement-group.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/source/ray-core/scheduling/placement-group.rst b/doc/source/ray-core/scheduling/placement-group.rst index 1b1b608d2a32..339c23bb4875 100644 --- a/doc/source/ray-core/scheduling/placement-group.rst +++ b/doc/source/ray-core/scheduling/placement-group.rst @@ -578,8 +578,8 @@ child tasks and actors to the same placement group, specify ``PlacementGroupSche :end-before: __child_capture_disable_pg_end__ .. warning:: - The value of ``placement_group_capture_child_tasks`` for a given actor is not inherited from its parent. If you are creating nested actors of depth greater than 1 - that should all use the same placement group, ``placement_group_capture_child_tasks`` should be explicitly set for each actor. + The value of ``placement_group_capture_child_tasks`` for a given actor isn't inherited from its parent. If you're creating nested actors of depth greater than 1 + and should all use the same placement group, you should explicitly set ``placement_group_capture_child_tasks`` explicitly set for each actor. [Advanced] Named Placement Group