Skip to content

[ci] Move simulate_storage from _private/ to _common/ #53735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 11, 2025
Merged

[ci] Move simulate_storage from _private/ to _common/ #53735

merged 11 commits into from
Jun 11, 2025

Conversation

@edoakes
Copy link
Collaborator

@edoakes edoakes commented Jun 11, 2025

Used by Train and Tune.

Only s3 type was used, so refactored.

edoakes added 9 commits June 11, 2025 10:31
@edoakes
move to _common
24d4f10 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
move to _common
8f65599 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
move to _common
39df40a 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
move to _common
c21185a 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
move to _common
8adfded 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
move to _common
a2a9a81 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
move to _common
91a1a50 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
move to _common
67cd866 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes
move to _common
339dfa4 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes requested review from a team and aslonnie as code owners June 11, 2025 15:38
@edoakes edoakes added the go add ONLY when ready to merge, run all tests label Jun 11, 2025
@edoakes edoakes requested a review from matthewdeng June 11, 2025 15:38
@edoakes
fix
4fdfd1b 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
justinvyu
justinvyu approved these changes Jun 11, 2025
View reviewed changes
Copy link
Contributor

@justinvyu justinvyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@edoakes
fix
59aeb2d 
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
@edoakes edoakes enabled auto-merge (squash) June 11, 2025 18:14
@edoakes edoakes disabled auto-merge June 11, 2025 19:31
@edoakes edoakes merged commit 0e9d93b into ray-project:master Jun 11, 2025
6 checks passed
elliot-barn pushed a commit that referenced this pull request Jun 18, 2025
@edoakes @elliot-barn
[ci] Move simulate_storage from _private/ to _common/ (#53735)
56bb49b 
Used by Train and Tune.

Only `s3` type was used, so refactored.

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
elliot-barn pushed a commit that referenced this pull request Jul 2, 2025
@edoakes @elliot-barn
[ci] Move simulate_storage from _private/ to _common/ (#53735)
bf7656f 
Used by Train and Tune.

Only `s3` type was used, so refactored.

---------

Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: elliot-barn <elliot.barnwell@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinvyu justinvyu justinvyu approved these changes

@aslonnie aslonnie aslonnie approved these changes

@matthewdeng matthewdeng Awaiting requested review from matthewdeng

Assignees

No one assigned

Labels

go add ONLY when ready to merge, run all tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@edoakes @justinvyu @aslonnie