[data] data metrics grouping #55495
Merged
[data] data metrics grouping #55495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: iamjustinhsu <jhsu@anyscale.com>
Signed-off-by: iamjustinhsu <jhsu@anyscale.com>
Signed-off-by: iamjustinhsu <jhsu@anyscale.com>
Signed-off-by: iamjustinhsu <jhsu@anyscale.com>
Signed-off-by: iamjustinhsu <jhsu@anyscale.com>
Signed-off-by: iamjustinhsu <jhsu@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request significantly improves the structure and maintainability of the Ray Data dashboard panels by refactoring them from a flat list into logically grouped, collapsible rows. The introduction of a PanelIdGenerator is a great addition to prevent ID collisions automatically. The changes also include renaming metrics like num_output_queue_* to num_external_inqueue_* for better clarity, which is reflected across the codebase. Overall, these are excellent changes. I have one minor suggestion to correct a metric description that was likely overlooked during the refactoring.
python/ray/data/_internal/execution/interfaces/op_runtime_metrics.py
Outdated
Show resolved
Hide resolved
iamjustinhsu
changed the title
Signed-off-by: iamjustinhsu <jhsu@anyscale.com>
iamjustinhsu
commented
Aug 13, 2025
Comment on lines
-327
to
-334
| num_output_queue_blocks: int = metric_field( | ||
| num_external_inqueue_blocks: int = metric_field( | ||
| default=0, | ||
| description="Number of blocks in the output queue", | ||
| description="Number of blocks in the external inqueue", | ||
| metrics_group=MetricsGroup.OUTPUTS, | ||
| ) | ||
| num_output_queue_bytes: int = metric_field( | ||
| num_external_inqueue_bytes: int = metric_field( | ||
| default=0, | ||
| description="Byte size of blocks in the output queue", |
Contributor
Author
There was a problem hiding this comment.
i changed these to be external INPUT queue, over external OUTPUT queue because it was easier to aggregate the sum of internal input queue + external queue per operator. Otherwise, I'm not sure how to sum the total queued inputs.
omatthew98
approved these changes
Aug 14, 2025
Contributor
omatthew98
left a comment
omatthew98
left a comment
There was a problem hiding this comment.
Lgtm from the data side, we should check with the observability team to make sure they aren't using any of the metrics we are changing the names of though.
| metrics_group=MetricsGroup.OUTPUTS, | ||
| ) | ||
| num_output_queue_blocks: int = metric_field( | ||
| num_external_inqueue_blocks: int = metric_field( |
Contributor
There was a problem hiding this comment.
@coqian FYI, if we rename some of these will it be a problem? Is the data dashboard using some of these metrics?
| # Overview Row | ||
| Row( | ||
| title="Overview", | ||
| id=99, |
Contributor
There was a problem hiding this comment.
Do the row ids collide with panel ids? Could we say start this at 0/1? Don't think it really matters either way.
Contributor
Author
There was a problem hiding this comment.
ya that must be unique
ray-gardener
bot
added
data
…/data-dashboard-grouping
can-anyscale
approved these changes
Aug 19, 2025
Contributor
can-anyscale
left a comment
can-anyscale
left a comment
There was a problem hiding this comment.
data team can decide
dioptre
pushed a commit
to sourcetable/ray
that referenced
this pull request
Aug 20, 2025
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> https://github.com/user-attachments/assets/8caa7448-35b1-4945-9e41-82fd9efca4f3 ## Why are these changes needed? - ray data dashboard is ugly - grouping them into pending inputs, inputs, outputs, overview, pending outputs, scheduling loop, resource usage/budget, and iteration - also changed the metric from external outqueue of op1 to external inqueue of op2 (so that i can combine the internal + external inqueues easily) <!-- Please give a short summary of the change and the problem this solves. --> ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: iamjustinhsu <jhsu@anyscale.com> Signed-off-by: Andrew Grosser <dioptre@gmail.com>
8 tasks
edoakes
pushed a commit
that referenced
this pull request
Sep 2, 2025
Since we introduced panel groups to Default (#55620) & Data (#55495) dashboards, applications consuming Grafana dashboards can comfortably embed the full dashboard on any UI now (and the other dashboards are pretty usable even without them). Added a `"supportsFullGrafanaView"` tag to the `rayMeta` list in Default Dashboard to indicate to consumers that we support full Grafana dashboard embedding from now on. --------- Signed-off-by: anmol <anmol@anyscale.com> Co-authored-by: anmol <anmol@anyscale.com>
sampan-s-nayak
pushed a commit
to sampan-s-nayak/ray
that referenced
this pull request
Sep 8, 2025
…roject#56077) Since we introduced panel groups to Default (ray-project#55620) & Data (ray-project#55495) dashboards, applications consuming Grafana dashboards can comfortably embed the full dashboard on any UI now (and the other dashboards are pretty usable even without them). Added a `"supportsFullGrafanaView"` tag to the `rayMeta` list in Default Dashboard to indicate to consumers that we support full Grafana dashboard embedding from now on. --------- Signed-off-by: anmol <anmol@anyscale.com> Co-authored-by: anmol <anmol@anyscale.com> Signed-off-by: sampan <sampan@anyscale.com>
jugalshah291
pushed a commit
to jugalshah291/ray_fork
that referenced
this pull request
Sep 11, 2025
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> https://github.com/user-attachments/assets/8caa7448-35b1-4945-9e41-82fd9efca4f3 ## Why are these changes needed? - ray data dashboard is ugly - grouping them into pending inputs, inputs, outputs, overview, pending outputs, scheduling loop, resource usage/budget, and iteration - also changed the metric from external outqueue of op1 to external inqueue of op2 (so that i can combine the internal + external inqueues easily) <!-- Please give a short summary of the change and the problem this solves. --> ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: iamjustinhsu <jhsu@anyscale.com> Signed-off-by: jugalshah291 <shah.jugal291@gmail.com>
jugalshah291
pushed a commit
to jugalshah291/ray_fork
that referenced
this pull request
Sep 11, 2025
…roject#56077) Since we introduced panel groups to Default (ray-project#55620) & Data (ray-project#55495) dashboards, applications consuming Grafana dashboards can comfortably embed the full dashboard on any UI now (and the other dashboards are pretty usable even without them). Added a `"supportsFullGrafanaView"` tag to the `rayMeta` list in Default Dashboard to indicate to consumers that we support full Grafana dashboard embedding from now on. --------- Signed-off-by: anmol <anmol@anyscale.com> Co-authored-by: anmol <anmol@anyscale.com> Signed-off-by: jugalshah291 <shah.jugal291@gmail.com>
wyhong3103
pushed a commit
to wyhong3103/ray
that referenced
this pull request
Sep 12, 2025
…roject#56077) Since we introduced panel groups to Default (ray-project#55620) & Data (ray-project#55495) dashboards, applications consuming Grafana dashboards can comfortably embed the full dashboard on any UI now (and the other dashboards are pretty usable even without them). Added a `"supportsFullGrafanaView"` tag to the `rayMeta` list in Default Dashboard to indicate to consumers that we support full Grafana dashboard embedding from now on. --------- Signed-off-by: anmol <anmol@anyscale.com> Co-authored-by: anmol <anmol@anyscale.com> Signed-off-by: yenhong.wong <yenhong.wong@grabtaxi.com>
dstrodtman
pushed a commit
that referenced
this pull request
Oct 6, 2025
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> https://github.com/user-attachments/assets/8caa7448-35b1-4945-9e41-82fd9efca4f3 ## Why are these changes needed? - ray data dashboard is ugly - grouping them into pending inputs, inputs, outputs, overview, pending outputs, scheduling loop, resource usage/budget, and iteration - also changed the metric from external outqueue of op1 to external inqueue of op2 (so that i can combine the internal + external inqueues easily) <!-- Please give a short summary of the change and the problem this solves. --> ## Related issue number <!-- For example: "Closes #1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: iamjustinhsu <jhsu@anyscale.com> Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
dstrodtman
pushed a commit
to dstrodtman/ray
that referenced
this pull request
Oct 6, 2025
…roject#56077) Since we introduced panel groups to Default (ray-project#55620) & Data (ray-project#55495) dashboards, applications consuming Grafana dashboards can comfortably embed the full dashboard on any UI now (and the other dashboards are pretty usable even without them). Added a `"supportsFullGrafanaView"` tag to the `rayMeta` list in Default Dashboard to indicate to consumers that we support full Grafana dashboard embedding from now on. --------- Signed-off-by: anmol <anmol@anyscale.com> Co-authored-by: anmol <anmol@anyscale.com> Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
bveeramani
pushed a commit
that referenced
this pull request
Oct 27, 2025
…pported operator filter (#57970) ## Description The per node metrics at OSS Ray Data dashboard are not displayed as expected. Because of this code change #55495, the following three metrics were added a filter for `operator`, which is [not supported](https://github.com/ray-project/ray/blob/e51f8039bc6992d37834bcff109a3d340e78fcde/python/ray/data/_internal/stats.py#L448) by per node metrics, and causes empty result. ray_data_num_tasks_finished_per_node ray_data_bytes_outputs_of_finished_tasks_per_node ray_data_blocks_outputs_of_finished_tasks_per_node Signed-off-by: cong.qian <cong.qian@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
<!-- Thank you for your contribution! Please review https://github.com/ray-project/ray/blob/master/CONTRIBUTING.rst before opening a pull request. --> <!-- Please add a reviewer to the assignee section when you create a PR. If you don't have the access to it, we will shortly find a reviewer and assign them to your PR. --> https://github.com/user-attachments/assets/8caa7448-35b1-4945-9e41-82fd9efca4f3 ## Why are these changes needed? - ray data dashboard is ugly - grouping them into pending inputs, inputs, outputs, overview, pending outputs, scheduling loop, resource usage/budget, and iteration - also changed the metric from external outqueue of op1 to external inqueue of op2 (so that i can combine the internal + external inqueues easily) <!-- Please give a short summary of the change and the problem this solves. --> ## Related issue number <!-- For example: "Closes ray-project#1234" --> ## Checks - [ ] I've signed off every commit(by using the -s flag, i.e., `git commit -s`) in this PR. - [ ] I've run `scripts/format.sh` to lint the changes in this PR. - [ ] I've included any doc changes needed for https://docs.ray.io/en/master/. - [ ] I've added any new APIs to the API Reference. For example, if I added a method in Tune, I've added it in `doc/source/tune/api/` under the corresponding `.rst` file. - [ ] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/ - Testing Strategy - [ ] Unit tests - [ ] Release tests - [ ] This PR is not tested :( --------- Signed-off-by: iamjustinhsu <jhsu@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…roject#56077) Since we introduced panel groups to Default (ray-project#55620) & Data (ray-project#55495) dashboards, applications consuming Grafana dashboards can comfortably embed the full dashboard on any UI now (and the other dashboards are pretty usable even without them). Added a `"supportsFullGrafanaView"` tag to the `rayMeta` list in Default Dashboard to indicate to consumers that we support full Grafana dashboard embedding from now on. --------- Signed-off-by: anmol <anmol@anyscale.com> Co-authored-by: anmol <anmol@anyscale.com>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
…pported operator filter (ray-project#57970) ## Description The per node metrics at OSS Ray Data dashboard are not displayed as expected. Because of this code change ray-project#55495, the following three metrics were added a filter for `operator`, which is [not supported](https://github.com/ray-project/ray/blob/e51f8039bc6992d37834bcff109a3d340e78fcde/python/ray/data/_internal/stats.py#L448) by per node metrics, and causes empty result. ray_data_num_tasks_finished_per_node ray_data_bytes_outputs_of_finished_tasks_per_node ray_data_blocks_outputs_of_finished_tasks_per_node Signed-off-by: cong.qian <cong.qian@anyscale.com>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
…pported operator filter (ray-project#57970) ## Description The per node metrics at OSS Ray Data dashboard are not displayed as expected. Because of this code change ray-project#55495, the following three metrics were added a filter for `operator`, which is [not supported](https://github.com/ray-project/ray/blob/e51f8039bc6992d37834bcff109a3d340e78fcde/python/ray/data/_internal/stats.py#L448) by per node metrics, and causes empty result. ray_data_num_tasks_finished_per_node ray_data_bytes_outputs_of_finished_tasks_per_node ray_data_blocks_outputs_of_finished_tasks_per_node Signed-off-by: cong.qian <cong.qian@anyscale.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
Future-Outlier
pushed a commit
to Future-Outlier/ray
that referenced
this pull request
Dec 7, 2025
…pported operator filter (ray-project#57970) ## Description The per node metrics at OSS Ray Data dashboard are not displayed as expected. Because of this code change ray-project#55495, the following three metrics were added a filter for `operator`, which is [not supported](https://github.com/ray-project/ray/blob/e51f8039bc6992d37834bcff109a3d340e78fcde/python/ray/data/_internal/stats.py#L448) by per node metrics, and causes empty result. ray_data_num_tasks_finished_per_node ray_data_bytes_outputs_of_finished_tasks_per_node ray_data_blocks_outputs_of_finished_tasks_per_node Signed-off-by: cong.qian <cong.qian@anyscale.com> Signed-off-by: Future-Outlier <eric901201@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2025-08-11.at.4.22.17.PM.mov
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.