diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 1099245c5932..76098364fd85 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -244,3 +244,22 @@ repos: files: '^python/ray/train/.*\.py$' pass_filenames: false args: ["--patch_dir", "ray/train/v2"] + + - repo: https://github.com/pre-commit/mirrors-eslint + rev: v8.26.0 + hooks: + - id: eslint + files: ^python/ray/dashboard/client/src/.*\.(tsx|ts)$ + types: [file] + args: + - --max-warnings=0 + additional_dependencies: + - eslint@8.26.0 + - eslint-plugin-react@7.31.10 + - eslint-plugin-import@2.26.0 + - eslint-config-react-app@7.0.1 + - eslint-plugin-prefer-arrow@1.2.3 + - '@typescript-eslint/parser@5.41.0' + - '@typescript-eslint/eslint-plugin@5.41.0' + - '@typescript-eslint/parser@5.41.0' + - '@typescript-eslint/eslint-plugin@5.41.0' diff --git a/ci/lint/check-dashboard-format.sh b/ci/lint/check-dashboard-format.sh index 7da5d053f4c8..46242e26445a 100755 --- a/ci/lint/check-dashboard-format.sh +++ b/ci/lint/check-dashboard-format.sh @@ -10,6 +10,5 @@ cd "${WORKSPACE_DIR}"/python/ray/dashboard/client || exit npm ci FILENAMES=($(find src -name "*.ts" -or -name "*.tsx")) -node_modules/.bin/eslint --max-warnings 0 "${FILENAMES[@]}" node_modules/.bin/prettier --check "${FILENAMES[@]}" node_modules/.bin/prettier --check public/index.html diff --git a/ci/lint/lint.sh b/ci/lint/lint.sh index a0fd779a84cc..dbd6aef6ff8f 100755 --- a/ci/lint/lint.sh +++ b/ci/lint/lint.sh @@ -38,6 +38,7 @@ pre_commit() { cpplint buildifier buildifier-lint + eslint ) for HOOK in "${HOOKS[@]}"; do