From fb4fd1a75ef715b9473e4e341692fdaf8f3ac954 Mon Sep 17 00:00:00 2001 From: elliot-barn Date: Tue, 21 Oct 2025 18:37:06 +0000 Subject: [PATCH 1/3] compiling all depsets in single job Signed-off-by: elliot-barn --- .buildkite/dependencies.rayci.yml | 22 ++-------------------- 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/.buildkite/dependencies.rayci.yml b/.buildkite/dependencies.rayci.yml index af2bf76b665d..086694c857b9 100644 --- a/.buildkite/dependencies.rayci.yml +++ b/.buildkite/dependencies.rayci.yml @@ -19,31 +19,13 @@ steps: job_env: oss-ci-base_test-py3.11 depends_on: oss-ci-base_test-multipy - - label: ":tapioca: build: raydepsets: compile LLM dependencies" - key: raydepsets_compile_llm_dependencies + - label: ":tapioca: build: raydepsets: compile all dependencies" + key: raydepsets_compile_all_dependencies tags: always instance_type: small commands: - bazel run //ci/raydepsets:raydepsets -- build ci/raydepsets/configs/rayllm.depsets.yaml --check - - chown -R 2000:100 /artifact-mount - - cp ./python/deplocks/llm/* /artifact-mount/ - job_env: manylinux - depends_on: manylinux - - - label: ":tapioca: build: raydepsets: compile ray img dependencies" - key: raydepsets_compile_rayimg_dependencies - tags: always - instance_type: medium - commands: - bazel run //ci/raydepsets:raydepsets -- build ci/raydepsets/configs/rayimg.depsets.yaml --check - job_env: manylinux - depends_on: manylinux - - - label: ":tapioca: build: raydepsets: compile multimodal inference release test dependencies" - key: raydepsets_compile_multimodal_inference_release_test_dependencies - tags: always - instance_type: medium - commands: - bazel run //ci/raydepsets:raydepsets -- build ci/raydepsets/configs/release_multimodal_inference_benchmarks_tests.depsets.yaml --check job_env: manylinux depends_on: manylinux From da25408562aa5464af0bc9b2e49ddc60dee1d1a9 Mon Sep 17 00:00:00 2001 From: elliot-barn Date: Tue, 21 Oct 2025 19:11:00 +0000 Subject: [PATCH 2/3] adding todo comment for build all command Signed-off-by: elliot-barn --- .buildkite/dependencies.rayci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.buildkite/dependencies.rayci.yml b/.buildkite/dependencies.rayci.yml index 086694c857b9..5605fa6d8475 100644 --- a/.buildkite/dependencies.rayci.yml +++ b/.buildkite/dependencies.rayci.yml @@ -24,6 +24,7 @@ steps: tags: always instance_type: small commands: + # TODO: add raydepsets build all command - bazel run //ci/raydepsets:raydepsets -- build ci/raydepsets/configs/rayllm.depsets.yaml --check - bazel run //ci/raydepsets:raydepsets -- build ci/raydepsets/configs/rayimg.depsets.yaml --check - bazel run //ci/raydepsets:raydepsets -- build ci/raydepsets/configs/release_multimodal_inference_benchmarks_tests.depsets.yaml --check From ba81810bbd05385c5a7613693a44b7b71a7c2f4b Mon Sep 17 00:00:00 2001 From: elliot-barn Date: Thu, 23 Oct 2025 02:46:48 +0000 Subject: [PATCH 3/3] outputing config name in error message for diff Signed-off-by: elliot-barn --- ci/raydepsets/cli.py | 2 +- ci/raydepsets/tests/test_cli.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ci/raydepsets/cli.py b/ci/raydepsets/cli.py index 478cd3a757e1..7136a757cdce 100644 --- a/ci/raydepsets/cli.py +++ b/ci/raydepsets/cli.py @@ -139,7 +139,7 @@ def diff_lock_files(self): diffs = self.get_diffs() if len(diffs) > 0: raise RuntimeError( - "Lock files are not up to date. Please update lock files and push the changes.\n" + f"Lock files are not up to date for config: {self.config_name}. Please update lock files and push the changes.\n" + "".join(diffs) ) click.echo("Lock files are up to date.") diff --git a/ci/raydepsets/tests/test_cli.py b/ci/raydepsets/tests/test_cli.py index 6287f64b6de2..74c7537bbc21 100644 --- a/ci/raydepsets/tests/test_cli.py +++ b/ci/raydepsets/tests/test_cli.py @@ -655,7 +655,7 @@ def test_diff_lock_files_out_of_date(self): with self.assertRaises(RuntimeError) as e: manager.diff_lock_files() assert ( - "Lock files are not up to date. Please update lock files and push the changes." + "Lock files are not up to date for config: test.depsets.yaml. Please update lock files and push the changes." in str(e.exception) ) assert "+emoji==2.8.0" in str(e.exception)