[examples] disable tests that have been failing #58015
Conversation
with comments to github issues Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
aslonnie
force-pushed
the
lonnie-251022-noexptest
branch
from
f0237f3 to
492ae1b
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request disables five failing example tests by changing their frequency to manual. This is a good approach to unblock the CI pipeline, and I appreciate you including links to the corresponding GitHub issues. I've suggested a small improvement to also mark these tests as stable: false. This will make them soft_fail if run manually, which better communicates their current failing state and helps with tracking.
| # https://github.com/ray-project/ray/issues/57222 | ||
| frequency: manual |
There was a problem hiding this comment.
Since this test is being disabled due to failures, it's a good practice to also mark it as stable: false. This will cause the test to soft_fail in Buildkite if it's run manually, which better reflects its known failing state. It also makes it easier to track unstable tests.
# https://github.com/ray-project/ray/issues/57222
stable: false
frequency: manual| # https://github.com/ray-project/ray/issues/57220 | ||
| frequency: manual |
There was a problem hiding this comment.
To better indicate that this test is known to be failing, please also mark it as stable: false. This will allow it to soft_fail if triggered manually and helps in tracking all unstable tests.
# https://github.com/ray-project/ray/issues/57220
stable: false
frequency: manual| # https://github.com/ray-project/ray/issues/57219 | ||
| frequency: manual |
There was a problem hiding this comment.
Consistent with other failing tests, it would be beneficial to mark this one as stable: false. This signals that the test is unstable and will cause it to soft_fail if run, providing a clearer status.
# https://github.com/ray-project/ray/issues/57219
stable: false
frequency: manual| # https://github.com/ray-project/ray/issues/57228 | ||
| frequency: manual |
There was a problem hiding this comment.
As this test is being disabled for failing, please add stable: false. This flag is useful for identifying all unstable tests and ensures it will soft_fail if executed manually.
# https://github.com/ray-project/ray/issues/57228
stable: false
frequency: manual| # https://github.com/ray-project/ray/issues/57224 | ||
| frequency: manual |
There was a problem hiding this comment.
To maintain consistency and clearly mark this test's status, please add stable: false. This will help in managing unstable tests and ensures it soft_fails on manual runs.
# https://github.com/ray-project/ray/issues/57224
stable: false
frequency: manualcherrypick #58015 Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
cherrypick #58015 Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
with comments to github issues Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: xgui <xgui@anyscale.com>
with comments to github issues Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
with comments to github issues Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
with comments to github issues