Fixes to tests #58317
Merged
Fixes to tests #58317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Comment on lines
+136
to
+138
| # 25.3 has breaking change where other Python packages like "click" does not work | ||
| # with it anymore. pip-compile will fail to work with the package's setup code. | ||
| "${python}" -m pip install pip==25.2 |
Contributor
There was a problem hiding this comment.
Pinning pip to a specific version can be a temporary solution. It would be beneficial to add a comment explaining why this version is being pinned and under what circumstances this pin can be removed. This helps future maintainers understand the context and avoid potential issues when upgrading pip later.
Consider adding a link to the pip release notes or a related issue for more context.
Suggested change
| # 25.3 has breaking change where other Python packages like "click" does not work | |
| # with it anymore. pip-compile will fail to work with the package's setup code. | |
| "${python}" -m pip install pip==25.2 | |
| # 25.3 has breaking change where other Python packages like "click" does not work | |
| # with it anymore. pip-compile will fail to work with the package's setup code. | |
| # Pinning to 25.2 to avoid this issue. See [link to issue or discussion] | |
| "${python}" -m pip install pip==25.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lint on code format and cherrypick #58215