[doc] fix invalid syntax in label_selector #58352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daraan <github.blurry@9ox.net>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly fixes invalid Python syntax in the documentation examples for bundle_label_selector and bundles within ray.util.placement_group. The original examples incorrectly attempted to multiply a dictionary by an integer, which would raise a TypeError. The provided fix changes this to multiply a list containing the dictionary, which is the correct idiom for creating a list with repeated elements. The changes are accurate and make the documentation examples correct and runnable.
ray-gardener
bot
added
docs
jjyao
approved these changes
Nov 1, 2025
edoakes
approved these changes
Nov 1, 2025
dayshah
approved these changes
Nov 1, 2025
YoussefEssDS
pushed a commit
to YoussefEssDS/ray
that referenced
this pull request
Nov 8, 2025
The current examples describe that label bundles are written as:
`[{"ray.io/accelerator-type": "H100"}* 2]`, i.e. a dict * integer.
This is wrong it has to be the list that is multiplied.
This PR fixes this.
Signed-off-by: Daraan <github.blurry@9ox.net>
landscapepainter
pushed a commit
to landscapepainter/ray
that referenced
this pull request
Nov 17, 2025
The current examples describe that label bundles are written as:
`[{"ray.io/accelerator-type": "H100"}* 2]`, i.e. a dict * integer.
This is wrong it has to be the list that is multiplied.
This PR fixes this.
Signed-off-by: Daraan <github.blurry@9ox.net>
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
The current examples describe that label bundles are written as:
`[{"ray.io/accelerator-type": "H100"}* 2]`, i.e. a dict * integer.
This is wrong it has to be the list that is multiplied.
This PR fixes this.
Signed-off-by: Daraan <github.blurry@9ox.net>
Signed-off-by: Aydin Abiar <aydin@anyscale.com>
SheldonTsen
pushed a commit
to SheldonTsen/ray
that referenced
this pull request
Dec 1, 2025
The current examples describe that label bundles are written as:
`[{"ray.io/accelerator-type": "H100"}* 2]`, i.e. a dict * integer.
This is wrong it has to be the list that is multiplied.
This PR fixes this.
Signed-off-by: Daraan <github.blurry@9ox.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current examples describe that label bundles are written as:
[{"ray.io/accelerator-type": "H100"}* 2], i.e. a dict * integer.This is wrong it has to be the list that is multiplied.
This PR fixes this.