Skip to content

Conversation

@aslonnie
Copy link
Collaborator

@aslonnie aslonnie commented Nov 6, 2025

python 3.9 is out of its life cycle

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
@aslonnie aslonnie requested a review from a team November 6, 2025 01:00
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This PR begins the process of removing the end-of-life Python 3.9 from the build process. The changes correctly stop the building of slim images with Python 3.9. However, the effort is incomplete as Python 3.9 is still referenced in numerous other build configurations. I've added a comment highlighting these other locations and suggesting that this PR either be expanded to be comprehensive or that a tracking issue be created to manage the remaining work. This is important to fully mitigate any risks associated with using an unsupported Python version.

- skip-on-release-tests
wanda: docker/base-slim/cpu.wanda.yaml
matrix:
- "3.9"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While removing Python 3.9 for the slim image builds is a good step, the broader goal of removing this EOL version from the project appears incomplete. Python 3.9 is still referenced in multiple other build configurations, for example in ci/docker/base.gpu.Dockerfile, ci/docker/base.test.Dockerfile, ci/docker/doc.build.Dockerfile, ci/docker/forge.Dockerfile, ci/docker/ray-core.Dockerfile, and ci/docker/windows.build.Dockerfile. To ensure consistency and completely remove the security risks of an EOL version, please consider either expanding this PR to remove all instances of Python 3.9, or creating a tracking issue for the remaining work.

@aslonnie aslonnie added the go add ONLY when ready to merge, run all tests label Nov 6, 2025
@ray-gardener ray-gardener bot added core Issues that should be addressed in Ray Core devprod labels Nov 6, 2025
@aslonnie aslonnie merged commit 403f450 into master Nov 6, 2025
6 checks passed
@aslonnie aslonnie deleted the lonnie-251105-nopy39slim branch November 6, 2025 04:43
YoussefEssDS pushed a commit to YoussefEssDS/ray that referenced this pull request Nov 8, 2025
python 3.9 is out of its life cycle

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
landscapepainter pushed a commit to landscapepainter/ray that referenced this pull request Nov 17, 2025
python 3.9 is out of its life cycle

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Aydin-ab pushed a commit to Aydin-ab/ray-aydin that referenced this pull request Nov 19, 2025
python 3.9 is out of its life cycle

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Signed-off-by: Aydin Abiar <aydin@anyscale.com>
ykdojo pushed a commit to ykdojo/ray that referenced this pull request Nov 27, 2025
python 3.9 is out of its life cycle

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Signed-off-by: YK <1811651+ykdojo@users.noreply.github.com>
SheldonTsen pushed a commit to SheldonTsen/ray that referenced this pull request Dec 1, 2025
python 3.9 is out of its life cycle

Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Issues that should be addressed in Ray Core devprod go add ONLY when ready to merge, run all tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants