-
Notifications
You must be signed in to change notification settings - Fork 7k
[image] stop building python 3.9 slim image bases #58418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR begins the process of removing the end-of-life Python 3.9 from the build process. The changes correctly stop the building of slim images with Python 3.9. However, the effort is incomplete as Python 3.9 is still referenced in numerous other build configurations. I've added a comment highlighting these other locations and suggesting that this PR either be expanded to be comprehensive or that a tracking issue be created to manage the remaining work. This is important to fully mitigate any risks associated with using an unsupported Python version.
| - skip-on-release-tests | ||
| wanda: docker/base-slim/cpu.wanda.yaml | ||
| matrix: | ||
| - "3.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While removing Python 3.9 for the slim image builds is a good step, the broader goal of removing this EOL version from the project appears incomplete. Python 3.9 is still referenced in multiple other build configurations, for example in ci/docker/base.gpu.Dockerfile, ci/docker/base.test.Dockerfile, ci/docker/doc.build.Dockerfile, ci/docker/forge.Dockerfile, ci/docker/ray-core.Dockerfile, and ci/docker/windows.build.Dockerfile. To ensure consistency and completely remove the security risks of an EOL version, please consider either expanding this PR to remove all instances of Python 3.9, or creating a tracking issue for the remaining work.
python 3.9 is out of its life cycle Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
python 3.9 is out of its life cycle Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
python 3.9 is out of its life cycle Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
python 3.9 is out of its life cycle Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: YK <1811651+ykdojo@users.noreply.github.com>
python 3.9 is out of its life cycle Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
python 3.9 is out of its life cycle