Skip to content

[doc] change link check to run on python 3.12 #58506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2025
Merged

[doc] change link check to run on python 3.12 #58506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .buildkite/doc.rayci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,12 @@ steps:
- api_policy_check

- label: ":book: doc: linkcheck"
key: doc_linkcheck
instance_type: medium
commands:
- make -C doc/ linkcheck_all
depends_on: docbuild
job_env: docbuild-py3.10
job_env: docbuild-py3.12
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While updating this step to Python 3.12 is correct, the PR description states a goal of migrating 'all doc related things'. To avoid potential inconsistencies in the build environment, the docbuild step, which this step depends on, should also be migrated to use a Python 3.12 environment. If that's handled in a separate PR, it would be good to link it for context.

tags:
- oss
- skip-on-premerge
Expand Down