[deps] upgrade lxml #58808
[deps] upgrade lxml #58808
Conversation
to latest version Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades the lxml dependency from version 4.9.4 to 6.0.2. This change is applied consistently across numerous lock files and requirement files to ensure compatibility with Python 3.13. The changes are straightforward dependency updates. I have one suggestion regarding the version specifier in python/requirements/test-requirements.txt to improve the reproducibility of test environments.
| kubernetes==24.2.0 | ||
| llvmlite==0.42.0 | ||
| lxml==4.9.4 | ||
| lxml>=6.0.2 |
There was a problem hiding this comment.
For better reproducibility of test environments, it is a good practice to pin dependency versions. Using >= could lead to different versions being installed in the future, potentially causing unexpected test failures. Pinning to ==6.0.2 ensures that the test environment remains consistent.
lxml==6.0.2
to latest version 6.0.2 4.9.4 does not work with python 3.13 Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
to latest version 6.0.2 4.9.4 does not work with python 3.13 Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
to latest version 6.0.2 4.9.4 does not work with python 3.13 Signed-off-by: Lonnie Liu <lonnie@anyscale.com> Signed-off-by: YK <1811651+ykdojo@users.noreply.github.com>
to latest version 6.0.2 4.9.4 does not work with python 3.13 Signed-off-by: Lonnie Liu <lonnie@anyscale.com>
to latest version 6.0.2
4.9.4 does not work with python 3.13