[core] Use secrets.token_hex(32) to generate auth tokens
#58818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves security by replacing uuid.uuid4() with the cryptographically stronger secrets.token_hex(32) for generating authentication tokens. The change is applied consistently across the token generator and its usage in tests. The new implementation is correct and well-documented. I've identified one critical issue in a test fixture where a parameter was not removed after its corresponding fixture was deleted, which would cause tests to fail. Please see the detailed comment.
Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
…es/gen-auth-token
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
richo-anyscale
approved these changes
Nov 19, 2025
Aydin-ab
pushed a commit
to Aydin-ab/ray-aydin
that referenced
this pull request
Nov 19, 2025
…ct#58818) Replace placeholder. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Aydin Abiar <aydin@anyscale.com>
edoakes
added a commit
to edoakes/ray
that referenced
this pull request
Nov 19, 2025
…ct#58818) Replace placeholder. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
aslonnie
pushed a commit
that referenced
this pull request
Nov 19, 2025
Cherry pick #58818 Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
400Ping
pushed a commit
to 400Ping/ray
that referenced
this pull request
Nov 21, 2025
…ct#58818) Replace placeholder. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
ykdojo
pushed a commit
to ykdojo/ray
that referenced
this pull request
Nov 27, 2025
…ct#58818) Replace placeholder. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: YK <1811651+ykdojo@users.noreply.github.com>
SheldonTsen
pushed a commit
to SheldonTsen/ray
that referenced
this pull request
Dec 1, 2025
…ct#58818) Replace placeholder. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace placeholder.