Skip to content

[Data] Add -s flag to test_backpressure_e2e.py #58977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bveeramani merged 1 commit into from
Nov 25, 2025
Merged

[Data] Add -s flag to test_backpressure_e2e.py #58977

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/ray/data/tests/test_backpressure_e2e.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,4 +338,4 @@ def __call__(self, df: np.ndarray):
if __name__ == "__main__":
import sys

sys.exit(pytest.main(["-v", __file__]))
sys.exit(pytest.main(["-sv", __file__]))
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better readability, it's good practice to separate combined short options into their own arguments. Additionally, adding a comment to explain why the -s flag is necessary for this specific test file would be helpful for future maintainers, given the inconsistency with other tests in the repository.

For example:

# The -s flag is added to ease debugging of flaky tests.
Suggested change
sys.exit(pytest.main(["-sv", __file__]))
sys.exit(pytest.main(["-s", "-v", __file__]))