Add find_map with any, first, and last variants
#627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuviper
approved these changes
Jan 23, 2019
There was a problem hiding this comment.
Looks good!
Can you please squash your commits? I don't mind multiple commits in a PR when they show progressive growth of a feature, but it looks like you're showing a few design iterations here, e.g. adding and then removing find_map.rs. Let's squash that to your final clean result.
Please run your additions through rustfmt too, as there are some differences.
seanchen1991
force-pushed
the
find_map
branch
from
7ae7b1c
to
0788fb6
Compare
Add non-working test for find_map_first Got find_map_first test compiling Get first test passing Remove unused file Need to write more comprehensive tests Add tests for find_map_any Add last newline back to find_first_last
|
FYI, GitHub doesn't always send notifications when you push new commits, so it helps to leave a comment. I also amended your commit with bors r+ |
bors bot
added a commit
that referenced
this pull request
Feb 19, 2019
627: Add `find_map` with `any`, `first`, and `last` variants r=cuviper a=seanchen1991 PR opened in response to #607. 633: Update dev and demo dependencies r=cuviper a=cuviper - `cgmath 0.17` - `glium 0.23` - `rand 0.6` Co-authored-by: Sean <seanchen11235@gmail.com> Co-authored-by: Josh Stone <cuviper@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR opened in response to #607.