modify condition to get t_bounds variable #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcaneill
reviewed
Sep 11, 2024
|
Could you add a test for this new feature? |
def test_use_preprocess_no_time_bound(data_path):
"""Test that if the time_bound variable does not exist, no error is raised"""
domcfg = open_domain_cfg(
datadir=data_path / "mesh_mask_1_file",
)
ds_raw = xr.open_dataset(data_path / "nemo/GYRE_1y_00010101_00011230_grid_T.nc")
ds_raw.encoding["source"] = "GYRE_1y_00010101_00011230_grid_T.nc"
ds_raw = ds_raw.drop_vars(ds_raw["time_counter"].attrs.get("bounds"))
ds = nemo_preprocess(ds_raw, domcfg)
assert "x_c" in ds
assert "t" in ds
assert ds["t"].attrs.get("bounds") is None |
|
(untested function) |
Co-authored-by: Romain Caneill <romain.caneill@ens-lyon.org>
…te exist but ot variable
|
The precommit error comes from the number of spaces around the new function |
rcaneill
reviewed
Sep 11, 2024
xnemogcm/test/test_nemo.py
Outdated
| @@ -146,7 +146,19 @@ def test_use_preprocess(data_path): | |||
| ds = nemo_preprocess(ds_raw, domcfg) | |||
| assert "x_c" in ds | |||
| assert "t" in ds | |||
|
|
|||
|
|
|||
rcaneill
reviewed
Sep 11, 2024
| ds = nemo_preprocess(ds_raw, domcfg) | ||
| assert "x_c" in ds | ||
| assert "t" in ds | ||
| assert ds["t"].attrs.get("bounds") is None | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some CDFTOOLs do not conserve the t_bounds variable but conserves the attribute, and thus xnemogcm fails when trying to get it.