Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploys lack feedback on execution errors, finalization, explorer #235

Open
dckc opened this issue Jul 10, 2021 · 7 comments
Open

deploys lack feedback on execution errors, finalization, explorer #235

dckc opened this issue Jul 10, 2021 · 7 comments
Labels
dev environment Anything affecting dev interface low priority ui UI / UX We need help!

Comments

@dckc
Copy link
Contributor

dckc commented Jul 10, 2021

for example, a link to the block in the https://revdefine.io explorer...
or info about whether the block is finalized
or whether executing the code resulted in an error

This is a TODO from 9c537aa

cc @Bill-Kunj

@Bill-Kunj Bill-Kunj added dev environment Anything affecting dev interface We need help! ui UI / UX labels Jul 11, 2021
@Bill-Kunj
Copy link
Collaborator

Bill-Kunj commented Jul 11, 2021

This is a TODO from 9c537aa

cc @Bill-Kunj

@dckc Yep, this would be good diagnostic info. Please flesh this out a bit more, though. The link you provide to the commit doesn't really explain anything.

@Bill-Kunj
Copy link
Collaborator

Bill-Kunj commented Jul 13, 2021

for example, a link to the block in the https://revdefine.io explorer...

@dckc I really like https://revdefine.io/. Provides excellent macro-view diagnostics.

or info about whether the block is finalized

It seems we would have to implement another call to the rnode in participate.js? I'm not sure how to go about that. My knowledge of the API isn't as good as yours.

or whether executing the code resulted in an error

Kinda thought this is apparent from the results section we display, but maybe it's not. Unless you're talking about the ambiguous error deploying rholang code, which we can't do anything about and, I thought, you were working to resolve with the core team.

This is a TODO from 9c537aa

cc @Bill-Kunj

I think each of these points is large enough to be worthy of an individual issue.

@Bill-Kunj
Copy link
Collaborator

No forward-looking effort on this, closing.

@dckc
Copy link
Contributor Author

dckc commented Aug 27, 2021

feel free to reflect a low priority in any way you like, but I think the app is deficient without this. Perhaps I should change it to a bug...

@dckc dckc reopened this Aug 27, 2021
@dckc dckc changed the title show block info for deploys deploys lack feedback on execution errors, finalization, explorer Aug 27, 2021
@dckc dckc added the bug Something is broken label Aug 27, 2021
@Bill-Kunj
Copy link
Collaborator

feel free to reflect a low priority in any way you like, but I think the app is deficient without this. Perhaps I should change it to a bug...

Agreed.

@Bill-Kunj Bill-Kunj added low priority and removed bug Something is broken labels Aug 27, 2021
@David405
Copy link
Collaborator

@dckc @Bill-Kunj how do you want the block info and what details do you want to be displayed? I can add that to the result data.

@dckc
Copy link
Contributor Author

dckc commented Aug 27, 2021

I can't think of a way to be more clear than what's in the description. Which part is not sufficiently clear?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev environment Anything affecting dev interface low priority ui UI / UX We need help!
Projects
None yet
Development

No branches or pull requests

3 participants