Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support devcontainer #134

Merged
merged 1 commit into from
Jan 20, 2024
Merged

Conversation

cndoit18
Copy link
Contributor

  • Add devcontainer support to use the development environment directly via vscode or codespaces.
  • Channel nightly-2023-10-09 did not successfully compile clippy-aarch64-unknown-linux-gnu, causing it to not run on arm64 machines.

@wyfcyx wyfcyx added the help wanted Extra attention is needed label Jan 17, 2024
@wyfcyx
Copy link
Collaborator

wyfcyx commented Jan 17, 2024

LGTM. I will merge this PR after bumping Rust to the latest channel.

Add devcontainer support to use the development environment directly via vscode or codespaces.

Signed-off-by: cndoit18 <cndoit18@outlook.com>
@cndoit18
Copy link
Contributor Author

LGTM. I will merge this PR after bumping Rust to the latest channel.

done

@jklincn
Copy link
Contributor

jklincn commented Jan 20, 2024

Verified: It can be used by local VSCode in combination with Docker and the Dev Containers extension.

@wyfcyx wyfcyx merged commit 8cd58cb into rcore-os:main Jan 20, 2024
wyfcyx added a commit that referenced this pull request Jan 20, 2024
wyfcyx added a commit that referenced this pull request Jan 20, 2024
wyfcyx added a commit that referenced this pull request Jan 20, 2024
wyfcyx added a commit that referenced this pull request Jan 20, 2024
wyfcyx added a commit that referenced this pull request Jan 20, 2024
wyfcyx added a commit that referenced this pull request Jan 20, 2024
wyfcyx added a commit that referenced this pull request Jan 20, 2024
wyfcyx added a commit that referenced this pull request Jan 20, 2024
wyfcyx added a commit that referenced this pull request Jan 20, 2024
wyfcyx added a commit that referenced this pull request Jan 20, 2024
wyfcyx added a commit that referenced this pull request Jan 20, 2024
@jklincn jklincn mentioned this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants