Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(types): Allow fill and justify settings for tabs #6391

Merged
merged 3 commits into from
Jul 6, 2022
Merged

feat(types): Allow fill and justify settings for tabs #6391

merged 3 commits into from
Jul 6, 2022

Conversation

mateusbw
Copy link
Contributor

@mateusbw mateusbw commented Jul 4, 2022

Allows the fill and justify props to be passed to <Tabs>

resolves: #6382

kyletsang
kyletsang reviewed Jul 4, 2022
View reviewed changes
Copy link
Member

@kyletsang kyletsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments, but looks good. Thanks!

src/Tabs.tsx Outdated Show resolved Hide resolved
www/src/pages/components/tabs.mdx Outdated Show resolved Hide resolved
@mateusbw mateusbw requested a review from kyletsang July 5, 2022 13:58
@kyletsang kyletsang merged commit 239c459 into react-bootstrap:master Jul 6, 2022
@kyletsang
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyletsang kyletsang kyletsang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Allow setting fill for <Tabs> as it's possible for <Nav>
2 participants
@mateusbw @kyletsang