Skip to content

Android: Fix not clickable via TalkBack #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Android: Fix not clickable via TalkBack #1190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions android/src/main/java/com/reactnativemenu/MenuView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,18 @@ class MenuView(private val mContext: ReactContext) : ReactViewGroup(mContext) {
prepareMenu()
}

override fun addView(child: View?, index: Int, params: ViewGroup.LayoutParams?) {
super.addView(child, index, params)
// Make child views trigger menu when clicked via TalkBack
child?.let {
it.isClickable = true
it.isFocusable = true
it.setOnClickListener {
performClick()
}
}
}

override fun onInterceptTouchEvent(ev: MotionEvent): Boolean {
return true
}
Expand All @@ -61,6 +73,14 @@ class MenuView(private val mContext: ReactContext) : ReactViewGroup(mContext) {
return true
}

override fun performClick(): Boolean {
super.performClick()
if (!mIsOnLongPress) {
prepareMenu()
}
return true
}

override fun onSizeChanged(w: Int, h: Int, oldw: Int, oldh: Int) {
super.onSizeChanged(w, h, oldw, oldh)
updateTouchDelegate()
Expand Down