This repository has been archived by the owner on Feb 8, 2020. It is now read-only.
fix: implement canGoBack for tab router #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satya164
force-pushed
the
@satya164/tab-can-go-back
branch
from
29026bd to
0e4e58c
Compare
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 93.04% 93.28% +0.24%
==========================================
Files 21 21
Lines 388 387 -1
Branches 97 93 -4
==========================================
Hits 361 361
+ Misses 26 25 -1
Partials 1 1
Continue to review full report at Codecov.
|
satya164
commented
Aug 9, 2019
| @@ -211,6 +211,10 @@ export default function TabRouter({ | |||
| return action.type === 'NAVIGATE'; | |||
| }, | |||
|
|
|||
| canGoBack(state) { | |||
| return router.getStateForAction(state, { type: 'GO_BACK' }) !== null; | |||
There was a problem hiding this comment.
this gave me an idea. we don't actually need to implement this method in routers. we can instead do this to implement canGoBack:
canGoBack: () =>
router.getStateForAction(getState(), BaseActions.goBack()) !== null ||
(parentNavigationHelpers && parentNavigationHelpers.canGoBack()) ||
false
osdnk
approved these changes
Aug 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.