Skip to content
This repository has been archived by the owner on Feb 8, 2020. It is now read-only.

feat: integrate reanimated based stack #42

Merged
merged 1 commit into from
Aug 6, 2019
Merged

Conversation

satya164
Copy link
Member

@satya164 satya164 commented Aug 5, 2019

ezgif-5-92c1a20cbab1

@satya164 satya164 requested a review from osdnk August 5, 2019 12:19
@codecov-io
Copy link

codecov-io commented Aug 5, 2019

Codecov Report

Merging #42 into master will decrease coverage by 0.44%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   93.81%   93.36%   -0.45%     
==========================================
  Files          21       21              
  Lines         372      377       +5     
  Branches       93       91       -2     
==========================================
+ Hits          349      352       +3     
- Misses         22       24       +2     
  Partials        1        1
Impacted Files Coverage Δ
packages/core/src/NavigationContext.tsx 100% <ø> (ø) ⬆️
packages/core/src/BaseActions.tsx 60% <ø> (ø) ⬆️
packages/core/src/SceneView.tsx 93.33% <ø> (ø) ⬆️
packages/core/src/useNavigationBuilder.tsx 100% <100%> (ø) ⬆️
packages/core/src/useNavigationCache.tsx 100% <100%> (ø) ⬆️
packages/core/src/useDescriptors.tsx 100% <100%> (ø) ⬆️
packages/core/src/BaseRouter.tsx 36.36% <0%> (-3.64%) ⬇️
packages/core/src/useOnAction.tsx 97.36% <0%> (+0.07%) ⬆️
...ges/core/src/__tests__/__fixtures__/MockRouter.tsx 96.42% <0%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1591a1d...cbf7cf1. Read the comment docs.

@satya164 satya164 force-pushed the @satya164/stack-navigator branch from 8924b07 to dd51fe5 Compare August 5, 2019 17:30
Copy link
Member

@osdnk osdnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to review it. Can you maybe make a pr with copied code firstly and then make a follow up pr to source branch with changes needed?

@osdnk
Copy link
Member

osdnk commented Aug 6, 2019

It's amazing!

@osdnk osdnk merged commit 7c67260 into master Aug 6, 2019
@osdnk osdnk deleted the @satya164/stack-navigator branch August 6, 2019 10:22
satya164 added a commit that referenced this pull request Aug 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants